Skip to content

Chore: [AEA-0000] - use gitleaks for secret scanning #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anthony-nhs merged 1 commit into from
Apr 17, 2026
Merged

Chore: [AEA-0000] - use gitleaks for secret scanning #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions .gitallowed
View file
Open in desktop

This file was deleted.

11 changes: 5 additions & 6 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,14 @@ repos:
types_or: [sh, shell]
pass_filenames: false

- repo: local
hooks:
- id: git-secrets
name: Git Secrets
description: git-secrets scans commits, commit messages, and --no-ff merges to prevent adding secrets into your git repositories.
- id: gitleaks
name: Git Leaks
description: gitleaks scans commits, commit messages, and --no-ff merges to
prevent adding secrets into your git repositories.
Comment on lines +80 to +81
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description claims this hook scans commit messages and --no-ff merges, but default_stages is pre-commit and this command is run in the pre-commit stage. Either adjust the description to match what’s actually being scanned (e.g., staged changes), or add an explicit commit-msg stage hook if commit message scanning is required.

Suggested change
description: gitleaks scans commits, commit messages, and --no-ff merges to
prevent adding secrets into your git repositories.
description: gitleaks scans staged changes during pre-commit to help
prevent secrets from being added to your git repository.

Copilot uses AI. Check for mistakes.
entry: bash
args:
- -c
- 'git-secrets --pre_commit_hook'
- "gitleaks git --pre-commit --redact --staged --verbose"
language: system
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hook doesn’t appear to use the file list that pre-commit will pass by default. To avoid unnecessary arguments (and potential OS argument-length issues on large commits), set pass_filenames: false (and consider always_run: true if you want secret scanning to run even when no files match).

Suggested change
language: system
language: system
pass_filenames: false
always_run: true

Copilot uses AI. Check for mistakes.

fail_fast: true
Expand Down