Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable CDK construct (SnsAlarm) to create a CloudWatch Alarm and publish alarm state changes to an SNS topic, along with Vitest coverage to validate defaulting/overrides.
Changes:
- Introduce
SnsAlarmconstruct (and supporting types/helpers) to standardise alarm creation and SNS wiring. - Add tests verifying “sane defaults” and override behaviour for alarm/metric configuration.
- Update
package-lock.jsondue to dependency resolution changes.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/cdkConstructs/src/constructs/SnsAlarm.ts | New construct for creating a CloudWatch alarm and attaching SNS actions, with defaults for common fields. |
| packages/cdkConstructs/tests/constructs/SnsAlarm.test.ts | New Vitest suite validating alarm synthesis and override behaviour. |
| package-lock.json | Lockfile updates (root package name + transitive dependency bumps). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Share SnsAlarm construct from PfP for use in PSU