Feature/cdapi 144#131
Conversation
williamjameswillis
left a comment
williamjameswillis
left a comment
There was a problem hiding this comment.
added some comments also my AI pointed out the following extras:
'The ticket explicitly requires: "Verify observability (logs, correlation IDs, traceability across systems)". No test in the IntEnvi suite checks response headers for a correlation ID (e.g. x-correlation-id). This is a direct gap against the acceptance criteria.'
There is no IntEnvi test for:
A missing Bearer token → expected HTTP 401
An invalid/expired Bearer token → expected HTTP 401
INTEGRATION.bru environment file is incomplete
environments/INTEGRATION.bru only declares secret variable names (PRIVATE_KEY_PATH, KID, PR_NUMBER, JWT_SECRET). However, Get_Auth_Token.bru uses {{APIM_ENV}} in its URL, which is not defined in the INTEGRATION environment. Running the auth token fetch against the integration environment will fail unless this is configured separately.
| } | ||
|
|
||
| assert { | ||
| res.status: eq 200 |
There was a problem hiding this comment.
can we do more than a 200 check
can we check the response body? can we check the e2e flow with MNS and/or PDM?
There was a problem hiding this comment.
Added additional assertions.
There was a problem hiding this comment.
isnt this identical to:
Test_PDM_Bundle_Succesful_Response_IntEnvi
There was a problem hiding this comment.
Yes, removed the duplicate test.
Added relevant logs from Cloudwatch on the ticket. |
|
|
Deployment Complete
|
2 participants
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.