[GPCAPIM-359] Sort out env vars#174
Conversation
|
Generally looks great, a lot to see here. Just a couple of extra points:
|
| log_details = { | ||
| "description": "PDS request", | ||
| "url": url, | ||
| "headers": headers, | ||
| } | ||
| logger.info(log_details) |
There was a problem hiding this comment.
I second this. I know we're not in any sensitive environments yet but this is the kind of thing we could accidentally leave in and cause problems. Better to filter out now and not have to come back to it (or just exclude header information for now if we just want to keep it simple)
| env="$1" | ||
| case "$env" in | ||
| int|int-pds|int-sds) | ||
| echo "how_do_we_do_this?" |
There was a problem hiding this comment.
Yeah this is a weird case isn't it. We're setup so that we can stub out the provider independently but the actual URL comes from SDS. We probably just need it to say "stub" or "not_stub". I think this is fine as-is for now and we can come back if / when we need to.
There was a problem hiding this comment.
I changed it to stub, while you were writing this comment. I think it was one of copilot's review comments - it not being a url!
It seems to make sense to have it as stub, so we have control over it for now and get test patients in to the stub that will make a full request work with SDS INT systems and PDS INT patients.
LMK if you want it changing back, or to not-stub.
…sed on the GET requests.
This reverts commit 55c5362.
|
|
Deployment Complete
|
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.