Skip to content

Conversation

@NishaSharma14
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.63%. Comparing base (2fc23ff) to head (8ea1ef9).
⚠️ Report is 1 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1314      +/-   ##
=================================================
+ Coverage          55.61%   56.63%   +1.02%     
  Complexity          2268     2268              
=================================================
  Files                207      207              
  Lines               8730     8733       +3     
=================================================
+ Hits                4855     4946      +91     
+ Misses              3875     3787      -88     
Flag Coverage Δ
unittests 56.63% <100.00%> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive feature tests for the Dataset controller and simplifies the public dataset route. The changes improve test coverage for dataset viewing, NMRium data management, versioning, and snapshot functionality, while also streamlining the route structure.

Key Changes:

  • Added 11 feature tests covering dataset controller endpoints including public/private access, NMRium info operations, versioning, and snapshot storage
  • Simplified public dataset route from datasets/{owner}/{slug} to datasets/{slug}
  • Refactored controller authorization logic to return JSON 401 response for private datasets instead of not rendering them

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 16 comments.

File Description
tests/Feature/DatasetTest.php New test file with comprehensive coverage for dataset controller endpoints, including public/private access, NMRium data operations, version tracking, and SVG snapshot storage
routes/web.php Simplified public dataset route by removing the {owner} parameter from the URL pattern
app/Http/Controllers/DatasetController.php Refactored authorization logic to return explicit JSON 401 response for non-public datasets instead of conditional rendering

@NishaSharma14 NishaSharma14 self-assigned this Dec 11, 2025
@vcnainala vcnainala merged commit 6637646 into development Dec 11, 2025
7 checks passed
@vcnainala vcnainala deleted the dataset-test branch December 11, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants