Elasticsearch - #541
Draft
afeefghannam89 wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two separate bugs in the Elasticsearch upgrade and keystore paths, plus one leftover line.
Keystore credentials never triggered a restart (#540)
The keystore tasks carried
changed_when: false, which also kills thenotify. Changing acredential therefore updated the keystore but Elasticsearch kept running with the old value
until some unrelated task happened to restart it.
A version bump upgraded all nodes at once (#546)
Update Elasticsearch if neededwas skipped on every host, so raisingelasticstack_versionfell through to the plain
package: state=presenttasks below it and every node was upgradedand restarted together. Three changes:
elasticstack-passwords.ymlnow persists the fetched elastic password withset_fact(
__elasticstack_password), so it is in scope no matter which role runs first.elasticstack-versions.ymlis no longer imported only forelasticstack_full_stack, sopackage_factsis always gathered and the installed-version comparison also works standalone.(
'elasticsearch' not in ansible_facts.packages). A version bump can now only take therolling path, and a broken rolling upgrade fails visibly instead of silently upgrading
everything.