-
Notifications
You must be signed in to change notification settings - Fork 2
Added intents-balance-history
#22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@race-of-sloths include |
|
@Megha-Dev-19 Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 5! @petersalomonsen received 25 Sloth Points for reviewing and scoring this pull request. We would appreciate your feedback or contribution idea that you can submit here What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
| "1D": [ | ||
| { | ||
| timestamp: 1694592000000, | ||
| date: "Sep 13", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to have a UTC date string here ( like the format of date.toJSON() ), and rather let the client convert to the locale / timezone settings?
The way it is now, it is unclear which timezone it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I will update it, or maybe we don't need date as all, we already have timestamp, the frontend can use timestamp to show the date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we use dates is for the postgress db, we store the historical data by grouping by date, so if we do by date.toJSON() it will be different for each timestamp, but we want to capture only 1 data set for each day/month/week, otherwise the dataset will be huge for all clients over time.
So I have added UTC for all timezones, and also updated in frontend to show "UTC" in the labels so it's clear.
petersalomonsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 5
Uh oh!
There was an error while loading. Please reload this page.