test(rds-net): widen mux_isolation propagation budgets for loaded macOS CI - #52
Merged
Merged
Conversation
…OS CI The sibling-isolation fixture polls distributed state: path-set propagation and NAT-traversal advertisement receipt/removal on the peer. On loaded macos-latest runners 2s was marginal — CI observed the client holding a validated IPv6 sibling while the server's path set had not yet observed it, failing terminal_child_receive_does_not_stop_healthy_path at the pre-fault observation wait. Raise the peer-observation waits (2s -> 8s sibling, 2s -> 5s advertisement) within the existing 15s outer budget. Local single-socket wait and functional-phase budgets are unchanged.
The connection driver learned validated paths only through the PathEvent::Established broadcast (capacity 32). A lagged receiver loses events permanently: a validated sibling path stayed invisible to path_stats, telemetry and reselection, which macOS CI exposed as mux_isolation timing out with the server never observing the client's IPv6 sibling. Rescan the bounded negotiated PathId space each driver iteration and adopt live paths whose PATH_RESPONSE was received — the same condition that emits Established — so event loss self-heals on the next loop turn. Unvalidated candidates still stay out of selection. Dead-path removal was already handled by reselect's retain.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terminal_child_receive_does_not_stop_healthy_pathflaked onmacos-latest(fix: remediate audit findings across desktop, sync, agent, discovery, relay, net, core #51 checks): the client held a validated IPv6 sibling while the server's observed path set had not yet propagated it inside the 2s poll budgetTest plan
cargo fmt --checkcargo clippy -p rds-net --all-targets --features transport-noq -- -D warningscargo test -p rds-net --features transport-noq --test mux_isolation— 3/3 green