fix(bench): refuse incomparable or insufficient suite reports - #35
Open
rldyourmnd wants to merge 1 commit into
Open
rldyourmnd wants to merge 1 commit into
rldyourmnd wants to merge 1 commit into
Conversation
The comparator only flagged missing scenarios and numeric drift; absent metrics, nonfinite values, failed scenarios, thin samples and backend/impairment profile mismatches compared silently. Each is now a fault:* refusal resolved before numbers are weighed, and --min-samples bounds percentile claims. The c1 checkpoint's noq suite gains the transport-noq feature flag it always required, and the r0-evidence gate is registered with a CLI negative-fixture battery. W0.4 partial. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rds-bench compareonly flagged missing scenarios and numeric drift; absent metrics, nonfinite values, failed scenarios, thin samples and backend/impairment profile mismatches compared silently (W0.4).fault:*refusal resolved before numbers are weighed;--min-samples(default 3) bounds percentile claims; the impairment seed stays outside the profile so same-conditions reruns compare.checkpoint.sh: c1's noq suite gains the--features transport-noqflag it always needed (--backend noqfails closed without it), and ther0-evidencegate is registered — fmt/clippy/test, rds-bench tests, and a generated negative-fixture battery where every entry must makecompareexit 1.docs/remediation-progress.mdW0.4 row + dated section. W0.4 stays partial (historical report re-qualification open).Test plan
cargo fmt --check,cargo clippy -p rds-bench --all-targets -- -D warnings,cargo test -p rds-bench(10 tests incl. every refusal path)bash -n scripts/checkpoint.shGenerated with Devin