fix(bench): end transfer timing at verified receiver receipt - #34
Open
rldyourmnd wants to merge 1 commit into
Open
rldyourmnd wants to merge 1 commit into
rldyourmnd wants to merge 1 commit into
Conversation
The transfer scenario stopped its timer when the sender finished writing, so a large send window or a stalled/truncated receiver could fabricate throughput. The TCP target now returns a fixed receipt — big-endian byte count and BLAKE3 digest after payload EOF, then response EOF — and the sender verifies all three under one operation deadline. Reports name the versioned scenario transfer-receiver-ack-v1 with verified-byte and completion metrics; historical sender-finish numbers stay incomparable by name. Receiver tasks are bounded and owned by the world. W0.2 partial; known-rate calibration and phase timings remain open. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transferbenchmark stopped its timer at sender finish; a large send window or truncated/stalled receiver could fabricate throughput (W0.2).transfer-receiver-ack-v1.bench-transfer-20260926-{iroh,noq}.{json,md}(debug profile, 32 MiB, verified goodput 4.4/3.7 MiB/s).docs/benchmark-transfer.md; progress:docs/remediation-progress.md(W0.2 stays partial — known-rate calibration and phase timings remain open).Test plan
cargo fmt --checkcargo clippy --locked --workspace --all-targets -- -D warnings(default + owned-transport lanes)cargo test -p rds-bench— 14 tests, incl. real iroh/noq forwarded-TCP receipts and invalid/missing/truncated receipt refusalsGenerated with Devin