Check Fortran compiler name instead of C compiler name #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is some logic in the CMakeLists.txt file that checks the name of the C compiler to determine if it is the GNU compiler. This logic should be changed to check the name of the Fortran compiler instead. This is important on a Mac where the C compiler is clang and the Fortran compiler is gfortran.
jedwards4b
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some logic in the CMakeLists.txt file that checks the name of the C compiler to determine if it is the GNU compiler. This logic should be changed to check the name of the Fortran compiler instead. This is important on a Mac where the C compiler is clang and the Fortran compiler is gfortran.
Without this change, I was getting build failures on my Mac in gptl and the tests. This change resolved those build failures (changing warnings to errors).