Add an npm run e2e script for the Algorithm Catalog - #229
Open
kyle-lesinger wants to merge 1 commit into
Open
Conversation
scripts/e2e.mjs landed last PR but was only reachable by typing the path, so it did not show up alongside dev / build / typecheck where someone would look for it. One line, no dependency change — `dependencies` stays react + react-dom and `devDependencies` is untouched, so `npm ci` on CI and Netlify is unaffected. Takes a base URL through npm's `--` passthrough: npm run e2e # localhost:5173 npm run e2e -- https://veda-algorithm-catalog.netlify.app Verified: `npm run e2e -- <production>` gives 16/16, typecheck and build clean.
✅ Deploy Preview for veda-github-actions canceled.
|
✅ Deploy Preview for veda-aws-dashboard canceled.
|
✅ Deploy Preview for veda-algorithm-catalog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for veda-dse-hub canceled.
|
✅ Deploy Preview for veda-leave-dashboard canceled.
|
✅ Deploy Preview for veda-pr-dashboard canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/e2e.mjslanded in #228 but was only reachable by typing the path, so it didn't appear alongsidedev/build/typecheckwhere someone would look for it.Takes a base URL through npm's
--passthrough:npm run e2e # localhost:5173 npm run e2e -- https://veda-algorithm-catalog.netlify.appNo dependency change.
dependenciesstaysreact+react-dom,devDependenciesis untouched, sonpm cion CI and Netlify is unaffected — Playwright is still resolved at run time with an install-instructions fallback.Verification
npm run e2e -- https://veda-algorithm-catalog.netlify.app→ 16/16npm run typecheck→ cleannpm run build→ cleanThis PR touches
algorithm-catalog/, so it produces a deploy preview.