Add Algorithm Catalog Netlify URL to README; correct the base-dir gotcha - #227
Merged
Conversation
The site is live at veda-algorithm-catalog.netlify.app, so replace the "Netlify site pending" placeholder with the real link, matching the other five dashboards. Also correct the Netlify note in docs/ALGORITHM_CATALOG.md. It predicted the first deploy would fail with "base directory not found" if run too early. That is not what happens when the base directory is left blank — the deploy goes GREEN and serves a 404. Netlify looks for netlify.toml at the repo root, finds none (deliberately — a root config's `base` would hijack all six sites), logs "Detected 0 framework(s) / No build steps found / Starting to deploy site from '/'", and uploads ~192 raw repo files with no index.html among them. Documents the tell to look for in the deploy log (`from '/'` vs `from 'algorithm-catalog/dist'`, ~192 files vs ~13), and the second way to get the same 404: filling in the publish directory as well, since `publish` in netlify.toml is relative to the base dir while the UI field is relative to the repo root, so setting both resolves algorithm-catalog/algorithm-catalog/dist. Notes that Netlify auto-installs Node 24 for this site, matching CI, so no NODE_VERSION variable is needed.
✅ Deploy Preview for veda-pr-dashboard canceled.
|
✅ Deploy Preview for veda-dse-hub canceled.
|
✅ Deploy Preview for veda-github-actions canceled.
|
✅ Deploy Preview for veda-leave-dashboard canceled.
|
✅ Deploy Preview for veda-algorithm-catalog canceled.
|
✅ Deploy Preview for veda-aws-dashboard canceled.
|
…s builds The comment claimed that omitting an `ignore` filter means the site always builds on every push. That is wrong. Because the site has a BASE DIRECTORY set, Netlify applies its own implicit check and skips the build when nothing under algorithm-catalog/ changed — with or without an `ignore` filter. Confirmed against two PRs: #220 touched aws-pricing/ + cost-dashboard/ and only veda-aws-dashboard produced a preview (the other four canceled); #227 touched only README.md + docs/ and all six canceled. So "Deploy Preview canceled" on a docs-only PR is correct behavior, not a misconfiguration — a preview for this app requires the PR to change a file inside algorithm-catalog/. Documented in docs/ALGORITHM_CATALOG.md so the next person doesn't go hunting through Netlify settings, as we just did. The rationale for not setting an `ignore` filter is unchanged and still stands: the older dashboards' folder-scoped `git diff` ignore skipped PRODUCTION builds when Netlify passed equal CACHED_COMMIT_REF/COMMIT_REF, silently dropping merged code.
…ir traps Records what this session established, split by audience so nothing is duplicated three times. .clinerules.md (must-follow rules + gotchas) - algorithm-catalog is the 6th site, no generator, cart -> prefilled PR - the standard lives in src/rules.ts and is MIRRORED in validate_data.py; rules_parity_test.py fails on drift, including a new exported constant - STAC event name: exactly 2 underscores, CamelCase hazards AND locations, serialize hazard ids not labels - products carry hazards (broad, discovery) + primaryHazards (sparse, auto-select); keep the subset relation and keep it sparse - .gitignore negation exception, and how to actually test it (git check-ignore --no-index -v; the plain form lies about tracked files) - the two Netlify traps below docs/DECISIONS.md (rationale) - why the catalog enforces a vocabulary upstream never did, and why the rule set is mirrored mechanically rather than merely documented as duplicated - why exactly-2-underscores is deliberately stricter than upstream, and why that direction is the safe one (everything we accept, DPS accepts) - why two hazard lists exist: discovery and defaults want opposite error tradeoffs, and auto-selecting from the broad list proposed 28 products - why negations beat `git add -f` for new apps - Netlify: base dir is load-bearing, and it earns free per-app build skipping AGENTS.md - Node 24 on CI and Netlify (auto-installed, no NODE_VERSION var) - the catalog's stdlib-only quick checks - rules.ts/validate_data.py mirror rule CLAUDE.md - the two Netlify traps, in the Gotchas section Both Netlify traps cost real time this session and neither is discoverable from the code: a blank base directory produces a GREEN deploy that 404s (no "base directory not found" error), and "Deploy Preview canceled" on a docs-only PR is correct behavior, not a misconfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Algorithm Catalog is live — https://veda-algorithm-catalog.netlify.app
README
Replaces the
_(Netlify site pending — base dir algorithm-catalog)_placeholder with the real link, so it matches the other five dashboards in the APPS !!! block.docs/ALGORITHM_CATALOG.md — corrects a wrong gotcha
The Netlify note predicted the first deploy would fail with "base directory not found" if run before
algorithm-catalog/existed on the built branch. That is not what happens when the base directory is left blank — and we hit the real failure setting this site up.It deploys green and serves a 404. Netlify looks for
netlify.tomlat the repo root, finds none (deliberately — a root config'sbasewould hijack all six sites), and logs:…then uploads ~192 raw repo files, none of which is an
index.htmlat the root. The deploy is marked successful, so nothing signals a problem except the 404.The updated note documents:
algorithm-catalog/netlify.tomlis the single source of truthfrom '/'+ ~192 files (broken) vsfrom 'algorithm-catalog/dist'+ ~13 files (correct)publishinnetlify.tomlis relative to the base dir (dist), but the UI field is relative to the repo root, so setting both resolvesalgorithm-catalog/algorithm-catalog/distNODE_VERSIONvariable neededVerification
The 16-check Playwright suite was re-run against the live Netlify deploy (not localhost) and passes 16/16: tab order, 8 algorithm cards, all 8 thumbnails loading, search narrowing 8 → 2, all 3 seed events, and the five negative event-name cases that must each block submission. Plus
/→ 200, a deep link → 200 (SPA redirect working), and/thumbs/sentinel2.png→ 200image/png.This PR is also the first one to exercise the new site's deploy preview.