Making LINK9 ~4x faster#230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After noticing some decks spent a significant fraction of their runtime in LINK 9 (output writing), @Copper280z and I ran some benchmarks. The conclusion? Fortran's
FORMATis depressingly slow, especially when you use it to format a bunch of floating-point numbers. The solution? A custom formatter, still written in Fortran, but bypassing theFORMATstuff.Two new subroutines have been introduced:
FMT_ES14_6andFMT_I8_RJ, and several subroutines inLK9have been modified to use the new utilities. Oh, and I also got rid of some array-zeroing loops because they also hinder performance.The result? Some output-heavy decks now spend 4x less time (from 2min to 30s) in LINK 9.
Thanks to @Copper280z and @victorkemp for participating in the discussion and helping cook up the benchmarks!