Models: Limit Measurement Value to Min/Max Value#18
Open
sanssecours wants to merge 1 commit intomainfrom
Hidden character warning
The head ref may contain hidden characters: "\ud83d\udcd0"
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While testing I noticed that for
acc100g_01the API was returning values below -100g. I assume the reason behind this is the offset value of
125.0. If the offset is correct, then I still think values below the minimum or above the physical max value are quite unexpected. This is why I opened this pull request. Can you please take a look at the changes Moritz and maybe explain why the current offset is125and not100?