Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LDAP modify flow to correctly rename Kerberos principals when sAMAccountName / userPrincipalName changes, by introducing a dedicated rename_princ operation across the Kerberos client/server stubs and adjusting tests accordingly.
Changes:
- Switch LDAP modify logic from
kadmin.modify_princ(...)tokadmin.rename_princ(...)for user/computer sAMAccountName-related renames. - Add
rename_princto the Kerberos kadmin abstraction (base/stub/client) and implement a new/principal/renameendpoint in the Kerberos config server. - Update API tests and test kadmin mocks to assert
rename_princusage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
app/ldap_protocol/ldap_requests/modify.py |
Uses rename_princ for principal renames and adjusts the RDN modification guard. |
app/ldap_protocol/kerberos/base.py |
Extends AbstractKadmin with rename_princ. |
app/ldap_protocol/kerberos/client.py |
Fixes modify endpoint payload/path; adds rename_princ client call. |
app/ldap_protocol/kerberos/stub.py |
Adds stubbed rename_princ. |
.kerberos/config_server.py |
Adds manager method + /principal/rename route to support principal renaming. |
tests/conftest.py |
Extends the mocked kadmin with rename_princ. |
tests/test_api/test_main/test_router/test_modify.py |
Updates assertions to expect rename_princ calls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
milov-dmitriy
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.