Skip to content

Add: migration: add sAMAccountName to Computers#966

Merged
Naksen merged 4 commits intodevfrom
bugfix/1364_add_samaccountname_to_computers
Mar 10, 2026
Merged

Add: migration: add sAMAccountName to Computers#966
Naksen merged 4 commits intodevfrom
bugfix/1364_add_samaccountname_to_computers

Conversation

@milov-dmitriy
Copy link
Collaborator

@milov-dmitriy milov-dmitriy commented Mar 10, 2026

Дано:
В рамках ПР #925 к Директориям-Компьютерам при создании добавляется атрибут sAMAccountName.

Проблема:
К уже существующим Директориям-Компьютерам не был добавлен атрибут sAMAccountName.

Решение:
Через миграцию добавить к уже существующим Директориям-Компьютерам атрибут sAMAccountName.

Задача: 1364

Copilot AI review requested due to automatic review settings March 10, 2026 08:21
@milov-dmitriy milov-dmitriy added the python Pull requests that update Python code label Mar 10, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Alembic migration to backfill sAMAccountName attributes for COMPUTER directories.

Changes:

  • Updated the interface subproject pointer.
  • Added an async Alembic migration to add/remove the sAMAccountName attribute for computer directories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
interface Bumps subproject commit reference.
app/alembic/versions/df4287898910_add_samaccountname_to_computers.py Adds upgrade/downgrade migration to backfill/remove sAMAccountName for computer directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milov-dmitriy milov-dmitriy requested a review from Copilot March 10, 2026 08:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@milov-dmitriy milov-dmitriy changed the title Add: migration add_samaccountname_to_computers task_1364 Add: migration: add sAMAccountName to Computers Mar 10, 2026
@milov-dmitriy milov-dmitriy requested a review from Copilot March 10, 2026 09:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Naksen Naksen merged commit 1478576 into dev Mar 10, 2026
6 checks passed
@Naksen Naksen deleted the bugfix/1364_add_samaccountname_to_computers branch March 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants