Repository navigation
Conversation
…sion 4) setScreenSize (columns, rows) replaces setViewWidthPx and is told to the game as NAWS by libmudlet and the stand-in; the statuses columns and viewWidthPx go. libmudlet reports consoleColors at load and on change, and passes a script's announce() on as an announce message. The self-test sends its measured console size. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…line Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
A text size setting, on a new settings screen reached from the game screen's title bar, sizes the console's text in sp, so the system font scale scales it too; a two-finger pinch on the console changes the same setting, and a slider with Smaller and Larger buttons is its accessible equivalent. The console measures its font's cell and sends the columns and rows that fit with setScreenSize once they have held for 200 ms, after a layout, rotation, keyboard or size change. Its default colours come from status consoleColors. Why the engine could not send something (status sendError, as for a failed sendHidden) now shows in a snackbar over the console's foot, which TalkBack reads. The sendError the engine resends after hello is not shown again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
…ck on black was Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
atTwiceTheSystemFontSizeNothingIsCutOff failed on API 28 and 36 with "'Disconnected' overflows its space", though the connection bar's state fits with room to spare. A String Text answers GetTextLayoutResult from ParagraphLayoutCache.slowCreateTextLayoutResultOrNull, which lays the text out again as a MultiParagraph at the last maximum width; MultiParagraph.width is that maximum while the result's size is the text's own width, so didOverflowWidth holds for every String Text narrower than its space. The check now takes didOverflowHeight, which still sees text squeezed or cut short, and text too wide for its space (the relayout wraps it into lines the real layout lacks), plus the widest line against the text's width. A failure names the size, the widest line and the height. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
setScreenSizeonce they have held for 200 ms: after layout, rotation, the keyboard showing or hiding, and a text size change.consoleColors.sendError, as for a failedsendHidden) shows in a snackbar that TalkBack reads; the copy the engine replays after hello is not shown again.data/Settings.kt: settings as Compose state over SharedPreferences; a new setting is one property and one row.Motivation for adding to Mudlet
Players need to read the game at a size that suits their screen and eyes, and the game needs the real width and height to wrap its text for it.
Other info (issues closed, discussion etc)
libmudletand a Qt front-end Mudlet#9011main, as Screen size, console colours and announcements over the protocol (version 4) #43's branch predates Input line: the masked field, the engine's history, a script's line, completion #40; Screen size, console colours and announcements over the protocol (version 4) #43's commits show here until it merges.TextSizeTest(setting, pinch, 200% font scale),GameScreenTest(colours) andInputLineTest(sendErrorread out, replay not shown); CI: https://github.com/Mudlet/android/actions/runs/43663146262; bite: https://github.com/Mudlet/android/actions/runs/43663198323 (expected red on exactly those 5 tests); device-only: on-device checklist item 17 indocs/architecture.md(pinch feel, TalkBack on the slider, keyboard and rotation each sending once).hasVisualOverflowis always true for a StringTextnarrower than its space (Compose relays it out at full width for semantics).🤖 Generated with Claude Code
https://claude.ai/code/session_016ujaeFyaqXXDx8xjoThE6J