Skip to content

Conversation

@allanlasser
Copy link
Member

As a staff user, I can view the org editing and member management pages, but I can't find them from the frontend.

@allanlasser allanlasser temporarily deployed to squarelet-pi-staff-org--ltn5wj December 17, 2025 18:00 Inactive
@allanlasser allanlasser requested review from duckduckgrayduck and removed request for mitchelljkotler December 18, 2025 16:13
@duckduckgrayduck
Copy link
Contributor

When I search for an organization to test this on and click on the organization, I receive a 500 error. https://muckrock.sentry.io/issues/7122148094/?project=1247105&query=is%3Aunresolved&referrer=issue-stream

@allanlasser allanlasser temporarily deployed to squarelet-pi-staff-org--ltn5wj December 18, 2025 16:44 Inactive
@allanlasser
Copy link
Member Author

@duckduckgrayduck Great catch, thanks. I just pushed up a fix and an accompanying test for this crash.

@allanlasser allanlasser temporarily deployed to squarelet-pi-staff-org--ltn5wj December 18, 2025 16:47 Inactive
@duckduckgrayduck
Copy link
Contributor

duckduckgrayduck commented Dec 18, 2025

Since this is a staff action, we should also log it similar to hijacks and editing a member page as a staff user. This is new_action in core/utils.py
b635350#diff-c4d896b0e329737bfc2878b9c57885e6501d5d48902766be6c0a3f5e30100e60

@allanlasser
Copy link
Member Author

allanlasser commented Dec 19, 2025

@duckduckgrayduck I agree with you, but I'd prefer to introduce that separately. This PR is intended to reveal the links to staff users as a short-term fix, and we've got updated handling for these pages in our redesign-orgs branch. Creating a small task to log staff interventions feels like an easy, worthwhile addition to that release. Are you ok with deferring this until then?

@duckduckgrayduck
Copy link
Contributor

That's fine with me

@allanlasser
Copy link
Member Author

Captured as #529

@allanlasser allanlasser self-assigned this Jan 5, 2026
@duckduckgrayduck duckduckgrayduck temporarily deployed to squarelet-pi-staff-org--3gbjpi January 6, 2026 14:31 Inactive
@duckduckgrayduck
Copy link
Contributor

Should we display an obvious banner that says "Staff control panel" similar to what we do on user profiles? Otherwise, this seems to work.

@allanlasser allanlasser temporarily deployed to squarelet-pi-staff-org--b199hc January 7, 2026 15:58 Inactive
@allanlasser
Copy link
Member Author

Should we display an obvious banner that says "Staff control panel" similar to what we do on user profiles? Otherwise, this seems to work.

Yep, good call! We've got that slated for the org page redesign (#532). But the intention in this set of changes is just to expose org admin actions to staff users, which isn't a "staff control".

@duckduckgrayduck
Copy link
Contributor

Sounds good, then I approve this

@allanlasser allanlasser merged commit 805061f into master Jan 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants