-
Notifications
You must be signed in to change notification settings - Fork 12
Expose org management links to MuckRock staff #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When I search for an organization to test this on and click on the organization, I receive a 500 error. https://muckrock.sentry.io/issues/7122148094/?project=1247105&query=is%3Aunresolved&referrer=issue-stream |
|
@duckduckgrayduck Great catch, thanks. I just pushed up a fix and an accompanying test for this crash. |
|
Since this is a staff action, we should also log it similar to hijacks and editing a member page as a staff user. This is new_action in core/utils.py |
|
@duckduckgrayduck I agree with you, but I'd prefer to introduce that separately. This PR is intended to reveal the links to staff users as a short-term fix, and we've got updated handling for these pages in our |
|
That's fine with me |
|
Captured as #529 |
|
Should we display an obvious banner that says "Staff control panel" similar to what we do on user profiles? Otherwise, this seems to work. |
Yep, good call! We've got that slated for the org page redesign (#532). But the intention in this set of changes is just to expose org admin actions to staff users, which isn't a "staff control". |
|
Sounds good, then I approve this |
As a staff user, I can view the org editing and member management pages, but I can't find them from the frontend.