Skip to content

Conversation

@allanlasser
Copy link
Member

@allanlasser allanlasser commented Dec 11, 2025

This one was a bit of a journey:

  1. I started by wanted to render the Share dialog at a larger size—it's very compacted now because our Modals all enforce a 48rem max-width.
  2. I refactored the Modal to support width and height overrides and a fillScreen layout mode.
  3. While refactoring the Modal and the Share dialog, I realized that we were applying padding to Modal content in a sub-optimal way.
  4. I updated all our Modal child components to use consistent padding—many of these were forms.
  5. I was able to refactor most common form styles into kit.css, which let me remove style rules from many of our form components.

End results:

  1. Share dialogs are way more useful since they present the embed at a more realisitic and readable size.
  2. We can now have variable size modals, but default to the same behavior as before.
  3. It's easier to enforce consistent style and layout across all our forms.

Two other small tweaks:

  • I added an .nvmrc so my system recognizes the Node version the project uses.
  • When I ran npm i, the package-lock file was updated with peer dependency annotations. This was unintentional.

Screenshots

Mobile sharing dialog now uses flex-wrap with a vertical overflow:
Screenshot 2025-12-11 at 12 00 00

Larger sharing modal that fills viewport:
Screenshot 2025-12-11 at 12 00 17

Note sharing modal at larger size:
Screenshot 2025-12-11 at 12 01 09

@netlify
Copy link

netlify bot commented Dec 11, 2025

Deploy Preview for documentcloud-frontend-next ready!

Name Link
🔨 Latest commit 190c4ff
🔍 Latest deploy log https://app.netlify.com/projects/documentcloud-frontend-next/deploys/693b16236df4bd0008f46cbb
😎 Deploy Preview https://deploy-preview-1226.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 39 (🔴 down 22 from production)
Accessibility: 0 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@allanlasser allanlasser requested a review from eyeseast December 11, 2025 19:06
@github-actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 26.45% 8647 / 32683
🔵 Statements 26.45% 8647 / 32683
🔵 Functions 47.8% 360 / 753
🔵 Branches 77.6% 1289 / 1661
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/accounts/Mailkey.svelte 100% 100% 100% 100%
src/lib/components/documents/Share.svelte 100% 50% 60% 100%
src/lib/components/forms/ChangeOwner.svelte 0% 0% 0% 0% 1-199
src/lib/components/forms/ConfirmDelete.svelte 0% 0% 0% 0% 1-111
src/lib/components/forms/ConfirmRedaction.svelte 0% 0% 0% 0% 1-89
src/lib/components/forms/DeleteProject.svelte 0% 0% 0% 0% 1-35
src/lib/components/forms/Edit.svelte 0% 0% 0% 0% 1-135
src/lib/components/forms/EditAccess.svelte 100% 100% 100% 100%
src/lib/components/forms/EditData.svelte 0% 0% 0% 0% 1-106
src/lib/components/forms/EditMany.svelte 0% 0% 0% 0% 1-148
src/lib/components/forms/EditNote.svelte 0% 0% 0% 0% 1-94
src/lib/components/forms/EditProject.svelte 0% 0% 0% 0% 1-79
src/lib/components/forms/EditSections.svelte 0% 0% 0% 0% 1-90
src/lib/components/forms/InviteCollaborator.svelte 0% 0% 0% 0% 1-69
src/lib/components/forms/Projects.svelte 0% 0% 0% 0% 1-154
src/lib/components/forms/RemoveCollaborator.svelte 0% 0% 0% 0% 1-53
src/lib/components/forms/Reprocess.svelte 0% 0% 0% 0% 1-242
src/lib/components/forms/UpdateCollaborator.svelte 0% 0% 0% 0% 1-60
src/lib/components/forms/UserFeedback.svelte 0% 0% 0% 0% 1-129
src/lib/components/layouts/Modal.svelte 100% 100% 0% 100%
src/lib/components/notes/Note.svelte 0% 0% 0% 0% 1-107
src/lib/components/sidebar/DocumentActions.svelte 0% 0% 0% 0% 1-206
src/lib/components/sidebar/ViewerActions.svelte 0% 0% 0% 0% 1-198
src/lib/components/viewer/PageActions.svelte 0% 0% 0% 0% 1-139
Generated in workflow #930 for commit 190c4ff by the Vitest Coverage Report Action

@allanlasser
Copy link
Member Author

I've identified a few more stories that need tweaked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants