This repository was archived by the owner on Dec 23, 2020. It is now read-only.
Presumed fix of exception when closing application window.#85
Open
AndersBillLinden wants to merge 1 commit intoMrCrayfish:masterfrom
Open
Presumed fix of exception when closing application window.#85AndersBillLinden wants to merge 1 commit intoMrCrayfish:masterfrom
AndersBillLinden wants to merge 1 commit intoMrCrayfish:masterfrom
Conversation
Contributor
Author
|
I may also add that the problem shows in at least windows 64-bit by only starting the application, closing the welcome screen and closing the application window with the X. |
Contributor
Author
|
Maybe the Display does not need to be destroyed in that handler... |
AndersBillLinden
force-pushed
the
trying-fix-close-exception
branch
from
22fd497 to
2dabb86
Compare
AndersBillLinden
force-pushed
the
trying-fix-close-exception
branch
from
2dabb86 to
ffaca66
Compare
AndersBillLinden
force-pushed
the
trying-fix-close-exception
branch
from
ffaca66 to
a8d53e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MrCrayfish!
I have noticed there is some glitch when closing the application window.
Maybe it is lwjgl that is hard to deinitialize without having unhandled exceptions.
The problem shows up as a messge when I try to close the application in form of a java message "Java(TM) Platform SE binary has stopped working".
This is an attempt to address the problem.
It will need some testing, if you ask me.
With this change: will the application properly close? Maybe it will go into an eternal loop? Or is the problem totally fixed?