Ide and toolchain changes #12
Conversation
…oss-compiler debugging support.
…n = 1` for consistent wide character handling.
…e `_USE_32BIT_TIME_T`, and automate DLL copying post-build.
…eLists.txt` for editor support.
…tor-specific functionality.
… paths, and streamline DLL copying logic in `CMakeLists.txt`.
…Lists.txt`. which get included in `Include.h`
…watch for C# changes, rebuild on updates, and link DLL to `Main`.
…dio launch configuration file.
…d clarify IDE-specific steps.
…actices and improve readability.
…o detect and respond to new/removed `.cs` files dynamically.
…th cross-platform build and run instructions
…c discovery and improve maintainability.
…g git submodules.
…ng, with locking to prevent parallel process issues.
Summary of ChangesHello @Mosch0512, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant overhaul of the project's build infrastructure, transitioning from a legacy Visual Studio solution to a more robust and maintainable CMake-driven system. The changes streamline the development process by automating dependency management, integrating .NET components directly into the CMake build, and providing updated IDE configurations. This modernization effort aims to improve the overall developer experience and facilitate future development. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request is a major and welcome improvement to the project's structure and build system. Migrating to a modern CMake-based setup and cleaning up the old Visual Studio project files is a great step forward. The new build instructions in the README are also much clearer.
I've found a few issues, mostly related to hardcoded paths and documentation inconsistencies, which should be addressed to ensure the build works smoothly for all contributors. The most critical issue is a hardcoded absolute path in the CLion configuration. I've also suggested improvements for NuGet package handling in the .csproj and adding the documented run target to the CMake script.
Overall, excellent work on modernizing the project's foundation!
…dling and environment variable overrides to fix issues with special characters in paths.
…s on build because normally they are in the user home which could contain umlauts
…, exclude `imgui` from all builds, and add `ConstantsReplacer` tool. Update `.vs/launch.vs.json` with a new configuration for `ConstantsReplacer`.
…uild output and dependencies for cleaner integration
…build settings for 32-bit and 64-bit platforms, and update .NET publishing process accordingly. Add x64 profiles to `.idea/cmake.xml` and `CMakeSettings.json`.
… architecture-specific settings, and configure `.idea/cmake.xml` to use the new toolchain.
…ed `x86` settings, improve automatic architecture inference in `CMakeLists.txt`, and update `toolchain-x64.cmake` for consistency. Update default server port.
…$(USERPROFILE) and adjust default folder path in ConstantsReplacer Form.
… builds with MSVC; improve asset and DLL copying in build setup.
…form support for x64 and x86 builds.
…lds, making it consistent with all other build methods
…files, ensuring consistency with x64 configuration
Mosch0512
force-pushed
the
ide-and-toolchain-changes
branch
from
71989ab to
bb6ac81
Compare
…e reliability, handle incomplete directories, and add missing submodules to the git index automatically.
No description provided.