Skill editor #11

Mosch0512 · 2026-01-14T21:25:33Z

No description provided.

gemini-code-assist · 2026-01-14T21:26:25Z

Summary of Changes

Hello @Mosch0512, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a significant new feature by integrating a full-fledged skill editor into the MuEditor. The editor provides a user-friendly interface for managing skill data, backed by a robust and modular data handling architecture. A key improvement is the adoption of a metadata-driven approach for UI rendering, which enhances flexibility for future data structure changes. Furthermore, the update expands the editor's internationalization capabilities with new language support and improved font rendering, making the tool more accessible to a global user base.

Highlights

New Skill Editor UI: Introduced a comprehensive graphical user interface for editing in-game skill attributes, allowing users to view, modify, save, and export skill data.
Modular Skill Data Handling: Refactored skill data operations (loading, saving, exporting) into dedicated, modular classes (SkillDataLoader, SkillDataSaver, SkillDataExporter, CSkillDataHandler) for improved maintainability and separation of concerns.
Metadata-Driven UI for Editors: Implemented a generic metadata system (FieldMetadataHelper.h) using X-macros and FieldDescriptors to define and render fields dynamically. This makes adding or modifying skill (and item) attributes more flexible and reduces UI code coupling.
Enhanced Internationalization (i18n): Added new translation files for German, Indonesian, Polish, Russian, and Filipino, and updated existing English, Spanish, and Portuguese translations to include all new skill editor strings and metadata. The editor's font loading now supports extended Unicode ranges for broader language compatibility.
Configurable Column Visibility: Users can now customize the visibility of columns in the new skill editor, with preferences automatically saved to the MuEditor.ini configuration file.
Legacy and CSV Export Options: The skill editor supports exporting data in a legacy S6E3 format for backward compatibility and also allows exporting skill data to CSV files for external analysis or bulk editing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a comprehensive Skill Editor feature, including a new UI, data handlers for loading/saving/exporting skill data, and extensive internationalization support. The refactoring to use X-Macros and a common metadata helper for both Item and Skill editors is a significant improvement for maintainability. However, there are several issues to address. Multiple new translation files contain untranslated English strings. There are also critical bugs in swprintf calls with incorrect arguments, and a hardcoded font path that will cause issues on systems where Windows is not installed on C:.

Source Main 5.2/source/MuEditor/Core/MuEditorCore.cpp

Source Main 5.2/source/MuEditor/UI/ItemEditor/ItemEditorActions.cpp

Source Main 5.2/source/MuEditor/UI/SkillEditor/SkillEditorActions.cpp

Source Main 5.2/bin/Translations/de/editor.json

Source Main 5.2/bin/Translations/pl/editor.json

Source Main 5.2/bin/Translations/pt/editor.json

Source Main 5.2/bin/Translations/ru/editor.json

Source Main 5.2/bin/Translations/tl/editor.json

Source Main 5.2/bin/Translations/uk/editor.json

Mosch0512 · 2026-01-15T00:06:19Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new Skill Editor, a significant feature that includes a data-driven UI, new data handlers for skill information, and extensive internationalization support for many new languages. The implementation is well-structured, notably with the excellent use of X-Macros for defining data structures and a generic metadata helper for UI rendering, which greatly improves maintainability and extensibility. The dynamic loading of available languages and enhanced Unicode font support are also major improvements. My review focuses on a few areas for improvement: completing translations in all language files, addressing code duplication for a helper function, and replacing platform-specific code for directory scanning to ensure cross-platform compatibility.

gemini-code-assist · 2026-01-15T00:08:51Z

Source Main 5.2/source/MuEditor/UI/Common/MuEditorUI.cpp

+            WIN32_FIND_DATAW findData;
+            const wchar_t* paths[] = {L"Translations\\*", L"bin\\Translations\\*"};
+
+            for (const wchar_t* basePath : paths)
            {
-                currentIndex = i;
-                break;
+                HANDLE hFind = FindFirstFileW(basePath, &findData);
+
+                if (hFind != INVALID_HANDLE_VALUE)
+                {
+                    do
+                    {
+                        if ((findData.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) &&
+                            wcscmp(findData.cFileName, L".") != 0 &&
+                            wcscmp(findData.cFileName, L"..") != 0)
+                        {
+                            // Convert wide string to narrow
+                            char localeCode[32];
+                            WideCharToMultiByte(CP_UTF8, 0, findData.cFileName, -1, localeCode, sizeof(localeCode), NULL, NULL);
+                            std::string locale = localeCode;
+
+                            // Build path to editor.json
+                            std::wstring editorJsonPath;
+                            if (wcscmp(basePath, L"Translations\\*") == 0)
+                            {
+                                editorJsonPath = std::wstring(L"Translations\\") + findData.cFileName + L"\\editor.json";
+                            }
+                            else
+                            {
+                                editorJsonPath = std::wstring(L"bin\\Translations\\") + findData.cFileName + L"\\editor.json";
+                            }
+
+                            // Read language name from JSON file
+                            std::string displayName = ReadLanguageName(editorJsonPath);
+
+                            // Fallback to locale code if reading failed
+                            if (displayName.empty())
+                            {
+                                displayName = locale;
+                            }
+
+                            availableLanguages.push_back({locale, displayName});
+                        }
+                    } while (FindNextFileW(hFind, &findData));
+
+                    FindClose(hFind);
+                }
+
+                // If we found languages, no need to try alternate path
+                if (!availableLanguages.empty())
+                {
+                    break;
+                }
+            }


The logic for auto-detecting available languages by scanning the Translations directory is implemented using Windows-specific APIs (WIN32_FIND_DATAW, FindFirstFileW, etc.). This will cause compilation errors or incorrect behavior on other platforms like macOS or Linux. Consider using a cross-platform library like C++17's <filesystem> or a third-party library to handle directory iteration.

Source Main 5.2/bin/Translations/es/editor.json

Source Main 5.2/bin/Translations/id/editor.json

Source Main 5.2/source/DataHandler/SkillData/SkillDataSaver.cpp

…IBUTE - Create GameData/SkillData/SkillStructs.h with SKILL_ATTRIBUTE definition - Remove duplicate SKILL_ATTRIBUTE from _struct.h, replace with include - SkillStructs.h is now single source of truth for ALL builds (editor and release) - Keep SKILL_ATTRIBUTE_FILE in _struct.h for binary file I/O - Establishes pattern: all game data structures will be organized in GameData/ directory This modernizes the codebase structure and eliminates duplicate definitions.

- Create SkillFieldDefs.h with X-macro definitions for all SKILL_ATTRIBUTE fields - Define 20 simple fields (Level, Damage, Mana, Distance, etc.) - Define 10 array fields (RequireDutyClass, RequireClass) - Include 2 DWORD fields (Distance, SkillBrand) using DWord type from Commit 1 - Add type helper macros for C++ type conversion - Total: 30 editable fields + Name field (31 columns in skill editor table) This is the single source of truth for skill field metadata.

- Created GameData/Common/FieldMetadataHelper.h with shared EFieldType enum, generic FieldDescriptor<TStruct> template, and RenderFieldByDescriptor() function - Refactored GameData/ItemData/ItemFieldMetadata.h (51% code reduction, 112 → 55 lines) - Created GameData/SkillData/SkillFieldMetadata.h using shared infrastructure - Added FIELD_TYPE_DWord to GameData/ItemData/ItemFieldDefs.h - Updated 9 ItemEditor files to use explicit ItemFieldDescriptor type - Fixed friend declaration to match generic template signature with 8 parameters Eliminates ~80 lines of duplication, establishes single source of truth for field metadata patterns, and prepares for future editors without code duplication.

- Added 20 skill field translations to bin/Translations/en/metadata.json (field_Damage, field_Mana, field_AbilityGuage, field_Distance, etc.) - Added 3 RequireDutyClass array field translations - Added skill-specific buttons, messages, and labels to bin/Translations/en/editor.json (btn_save_skills, msg_save_skills_success, label_skill_editor_title, etc.) Note: Some fields (field_Level, field_Strength, field_Dexterity) already existed from item editor and are reused for skills.

- Created DataHandler/SkillData/SkillDataLoader.h/cpp - Ported logic from ZzzInfomation.cpp::OpenSkillScript() (lines 245-294) - Implements file size verification (88 bytes × 650 + 4 = 57,204 bytes) - Checksum verification using GenerateCheckSum2() with magic key 0x5A18 - BuxConvert decryption for each skill entry - UTF-8→UTF-16 string conversion for skill names via CMultiLanguage::ConvertFromUtf8() - Logs to MuEditorConsoleUI instead of MessageBox for better editor UX - Operates on global SkillAttribute array

- Created DataHandler/SkillData/SkillDataSaver.h/cpp - Automatic .bak file creation before saving - Change tracking system using X-macros for field-by-field comparison - UTF-16→UTF-8 conversion for skill names via CMultiLanguage::ConvertToUtf8() - BuxConvert encryption for each skill entry - Checksum generation using GenerateCheckSum2() with magic key 0x5A18 - Detailed change log showing old→new values for modified fields - Logs to MuEditorConsoleUI with success message and modification count - Operates on global SkillAttribute array

- Created DataHandler/SkillData/SkillDataExporter.h/cpp - X-macro driven CSV generation using SKILL_FIELDS_SIMPLE and SKILL_FIELDS_ARRAYS - UTF-8 BOM for proper encoding in Excel/LibreOffice - CSV header automatically generated from field definitions (31 columns) - UTF-16→UTF-8 conversion for skill names via WideCharToMultiByte() - Quote escaping for CSV safety (doubles quotes in skill names) - Only exports skills with non-empty names - Logs exported count to MuEditorConsoleUI - Operates on global SkillAttribute array

- Created DataHandler/SkillData/SkillDataHandler.h/cpp - Singleton pattern matching ItemDataHandler architecture - Delegates Load() to SkillDataLoader (available in all builds) - Delegates Save() and ExportToCsv() to SkillDataSaver/Exporter (editor-only) - Provides data access methods: GetSkillAttributes(), GetSkillAttribute(), GetSkillCount() - Bounds checking in GetSkillAttribute() returns nullptr for invalid indices - Non-copyable singleton with deleted copy constructor and assignment operator - Macro g_SkillDataHandler for convenient access - Operates on global SkillAttribute array

- Modified ZzzOpenData.cpp to use g_SkillDataHandler.Load() instead of OpenSkillScript() - Added include for DataHandler/SkillData/SkillDataHandler.h - Applies to ALL builds (editor and release), not just editor builds - SkillDataHandler provides cleaner abstraction and better error handling - Editor builds log to console, release builds show MessageBox errors - Old OpenSkillScript() function in ZzzInfomation.cpp now deprecated - Consistent with ItemDataHandler migration pattern

- Created MuEditor/UI/SkillEditor/SkillEditorColumns.h/cpp - X-macro-driven rendering using SkillFieldDescriptor - Delegates to generic RenderFieldByDescriptor template from FieldMetadataHelper.h - Type-specific rendering: Byte, Word, Int, DWord, Bool, WCharArray - RenderIndexColumn for skill index swapping with bounds checking (MAX_SKILLS) - UTF-8 conversion for skill names via WideCharToMultiByte/MultiByteToWideChar - Logs all changes to MuEditorConsoleUI - Works with global SkillAttribute array - Supports DWORD fields for Distance and SkillBrand

- Created MuEditor/UI/SkillEditor/SkillEditorTable.h/cpp - Case-insensitive skill name filtering with UTF-8 conversion - ImGui table with resizable/reorderable/hideable/sortable columns - Column freezing support for Index and Name columns - Virtual scrolling with ImGuiListClipper for 650 skills - Metadata-driven column setup using GetSkillFieldDescriptors() - Delegates row rendering to CSkillEditorColumns - Static RequestScrollToIndex() for navigation - Works with MAX_SKILLS (650) instead of MAX_ITEM - Updated SkillEditorColumns.cpp to include SkillEditorTable.h - add GetSkillFieldDisplayName() function to SkillFieldMetadata.h

- Created MuEditor/UI/SkillEditor/SkillEditorActions.h/cpp - Save button calls g_SkillDataHandler.Save() with changelog tracking - Export CSV button calls g_SkillDataHandler.ExportToCsv() - Metadata-driven export helpers for CSV and readable formats - GetFieldValueAsString() supports all field types including DWord - UTF-8 conversion for skill names - Created MuEditor/UI/SkillEditor/SkillEditorPopups.h/cpp - Success/failure popups for Save and Export CSV operations - Changelog display in save success popup - Static state management for popup visibility - RenderPopups() to display all active modal dialogs

- Created MuEditor/UI/SkillEditor/MuSkillEditorUI.h/cpp - Singleton pattern with g_MuSkillEditorUI define - Main ImGui window with translated "Skill Editor" title - Case-insensitive search bar for filtering skills by name - Column visibility menu with Select All/Unselect All buttons - Freeze columns checkbox (freezes Index and Name columns) - Window position clamping between toolbar and console - Integrates SkillEditorTable, SkillEditorActions, SkillEditorPopups - Default visible columns: Name, Level, Damage, Mana, Distance, Delay, Energy, Strength, Dexterity - Saves/loads column preferences via MuEditorConfig - Hover detection for input blocking

Add skill editor column visibility persistence to the configuration system. Methods GetSkillEditorColumnVisibility() and SetSkillEditorColumnVisibility() now allow MuSkillEditorUI to save/load column preferences. Changes: - Add GetSkillEditorColumnVisibility() and SetSkillEditorColumnVisibility() methods - Add m_skillEditorColumnVisibility map member - Update Load() to parse [SkillEditorColumnVisibility] section - Update Save() to write [SkillEditorColumnVisibility] section - Fix: Escape backslash in m_configPath ("MuEditor\\MuEditor.ini")

Add skill editor window rendering support to the editor core. The skill editor window is now conditionally rendered when m_bShowSkillEditor is true. Changes: - Add m_bShowSkillEditor member and IsShowingSkillEditor() accessor - Include MuSkillEditorUI.h header - Initialize m_bShowSkillEditor to false in constructor - Render skill editor window in Render() when m_bShowSkillEditor is true - Save skill editor column preferences in Shutdown()

Add skill editor button to the main toolbar next to the Item Editor button. The button toggles the skill editor window visibility. Changes: - Update RenderToolbar() and RenderToolbarFull() to accept showSkillEditor parameter - Add "Skill Editor" button in toolbar after "Item Editor" button - Update MuEditorCore to pass m_bShowSkillEditor to RenderToolbar() - Update MuEditorCenterPaneUI to render skill editor window

… (Tagalog) translations for editor UI, metadata, and game placeholders.

… UI language selector with dynamic population based on available translations.

…ng in MuEditor.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

…support; fallback to default font if unavailable.

…roved readability and maintainability.

…place existing implementations.

…emDataExporter` for consistency and reusability

gemini-code-assist bot reviewed Jan 14, 2026

View reviewed changes

Mosch0512 force-pushed the add-imgui-and-item-editor branch from 647353a to 64bc941 Compare January 14, 2026 21:35

Mosch0512 force-pushed the skill-editor branch 4 times, most recently from 0211224 to 40757ec Compare January 14, 2026 23:55

gemini-code-assist bot reviewed Jan 15, 2026

View reviewed changes

Mosch0512 force-pushed the skill-editor branch 2 times, most recently from 2c788a2 to 8721688 Compare January 15, 2026 01:02

Mosch0512 force-pushed the add-imgui-and-item-editor branch from 6ef9588 to c7100da Compare January 16, 2026 14:43

Mosch0512 force-pushed the skill-editor branch from 91ad71b to ecf6cc8 Compare January 17, 2026 00:28

Mosch0512 force-pushed the add-imgui-and-item-editor branch 2 times, most recently from 02386a3 to 562245e Compare January 18, 2026 20:16

Mosch0512 added 15 commits January 18, 2026 22:31

add DWORD field type support to metadata system

aa4cc09

Mosch0512 and others added 18 commits January 18, 2026 22:31

Included German, Indonesian, Polish, Russian, Ukrainian, and Filipino…

8990026

… (Tagalog) translations for editor UI, metadata, and game placeholders.

Auto-detect and integrate language metadata for translations; enhance…

4ede9c8

… UI language selector with dynamic population based on available translations.

Load extended Unicode font support for multilingual character renderi…

7488af0

…ng in MuEditor.

add missing translations

9f68096

Make skill export to csv button green

44200c1

Move change saves info into editor console

ea5553d

Match the item save change editor logs

78de899

Add legacy skill format support and export functionality

ad26713

Improve naming of Export S6E3 functions

09e717e

Remove unused OpenSkillScript function

0bc4a5a

Remove extra argument

79030b9

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Dynamically load platform-specific system fonts for extended Unicode …

6e903cb

…support; fallback to default font if unavailable.

Refactor language directory scanning to use std::filesystem for imp…

bcf3dd6

…roved readability and maintainability.

Extract WideToNarrow helper to StringUtils for reusability and re…

3041d4c

…place existing implementations.

Replace WideCharToMultiByte with StringUtils::WideToNarrow in `It…

ebd5a32

…emDataExporter` for consistency and reusability

Fix after rebase

ecaeeca

Mosch0512 force-pushed the skill-editor branch from ecf6cc8 to ecaeeca Compare January 18, 2026 21:33

Mosch0512 merged commit 95d913f into add-imgui-and-item-editor Jan 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Skill editor #11

Skill editor #11

Uh oh!

Mosch0512 commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mosch0512 commented Jan 15, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 15, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Skill editor #11

Skill editor #11

Uh oh!

Conversation

Mosch0512 commented Jan 14, 2026

Uh oh!

gemini-code-assist bot commented Jan 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Mosch0512 commented Jan 15, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants