Repository navigation
Use \diffvpredvar, and fix the PDF title that breaks the publish - #618
Conversation
Moves the latex-macros pin to Morrison-Lab/macros#426, which adds \diffvpredvar, and uses it in the odds-multiplier results in place of the hand-written \diff \vpredvar, as rme uses \diffvx (sds#617). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9qrViJfWgYsyX5QcEX
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Quarto puts a theorem-type title in the optional argument of
\begin{example}[...], so the "]" of $[0, \highend]$ closed that
argument early and pdflatex stopped with "Extra }, or forgotten $" on
exponential-families.qmd. Every Quarto Publish run on main has failed
this way since 2026-11-12 04:25 UTC, so the site has not republished.
Bracing the math keeps the "]" inside a group; the output is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9qrViJfWgYsyX5QcEX
|
Claude finished review — View run I fetched PR #618 live just now. It is open, not a draft, and not merged. Its head is still This round's change is one line. The heading in VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "96783418993df47632213ceb2e2421b3ce7363d2",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only new change, in _exm-uniform-not-exponential-family.qmd line 2, wraps the interval in braces within the heading math, which is valid LaTeX and keeps the semantic highend macro.",
"holistic_assessment": "The change is scoped to the PDF compile fix, leaves the prior notation review untouched, and affects no page paths or anchors; a PDF render was not run."
}Reviewed commit: 9678341 |
Built to branch |
|
Annotation dispositions for head 9678341: I read the 55 annotations on all 51 check runs of 9678341, in 5 groups.
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Cross-harness review (agy Flash) on 9678341: VERDICT: CLEAN Every Posted by Claude Code (AI agent) --- not written by a human. |
|
Narrowing a claim in my review above I wrote that no other title can fail the same way. What I measured is narrower: on sds main (9f42c4e, tracked files only, no submodules), a heading of any level in the two lines after a theorem-type div opener ( Posted by Claude Code (AI agent) --- not written by a human. |
🤖 Generated with Claude Code
https://claude.ai/code/session_019xfc9qrViJfWgYsyX5QcEX
Closes #617.
Why
Ezra asked why the odds-multiplier results from sds#614 wrote out
\diff \vpredvarinstead of using a shorthand macro, as rme uses\diffvx.macros#426 added
\diffvpredvar.Changes
latex-macrospin frome445125toae1d822, the merge of macros#426.The bump spans 115 commits; besides
\diffvpredvar, they add macros (for example\ccprod,\quadmodeland\sqprederr) and change the CI wiring in macros.Only two existing definitions change in
macros.qmd, and neither changes what it prints:\designis now\mdesign, which is\matr{D}as before (sds uses it in_rem-cross-product-matrix.qmd), and\stprodnow routes through\ccprod, which is the same\tp{#1} #2. The PR preview is the full check.\diff \vpredvarwith\diffvpredvarin the six odds-multiplier subfiles oflogistic-inference.qmd. That's 19 occurrences, and it changes no rendered output: the macro prints the same Δx̰.\difflogoddsis not used here.The sds proofs never write a difference of log-odds, so adopting it would mean adding a new definition, which is beyond this swap.
Also: fix the failing publish (9678341)
Every
Quarto Publishrun onmainhas failed since 2026-11-12 04:25 UTC (for example run 43370603721), so the site has not republished, and sds#614's new anchors are not live yet.pdflatex stops on
exponential-families.qmdwith "Extra }, or forgotten $".Quarto puts the title of
#exm-uniform-not-exponential-familyin the optional argument of\begin{example}[...], and the]in$[0, \highend]$closed that argument early.Writing the math as
${[0, \highend]}$keeps the]inside a group, and the rendered title is unchanged.Locally,
quarto render exponential-families.qmd --to pdffails with that error before the change and succeeds after it.It is in this PR, not a separate one, because it blocks the publish that the odds-multiplier links in lds#2430 and rme#1497 need.
Checks
quarto render logistic-inference.qmd --to htmlgives no warnings, and the rendered theorem shows\Deltafollowed by the vector x̰, as before.Generated by Claude Code