[d-morrison]

Requested by Ezra · project thread

Closes #215.

Why

mcs, pds, sds, psw and lds save the reader's palette under lds-theme and read mln-theme as a fallback. qwt still saves it under mln-theme. Each of those repos vendors theme-picker.html and qwt-reveal-toggle.html from qwt through sync-site-scaffolding.yml (Mondays 07:00 UTC), so the next sync would open PRs switching them back to mln-theme. Readers' saved themes would then be lost.

What

• theme-picker.html and qwt-reveal-toggle.html are now byte-identical to pds's copies. pds's theme-picker.html is also byte-identical to lds's and sds's.
• CLAUDE.md names the new key.

The reading fallback keeps a choice saved under mln-theme, so no reader loses their theme.

Downstream effect of the next sync

• mcs, sds and psw: their copies have the same code as pds and differ only in comment wording, so the sync PR there changes comments only.
• mds and psc: still on mln-theme, so the sync PR there moves them to lds-theme with the fallback. No saved choice is lost.

---

Generated by Claude Code

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

[github-actions]

Claude finished review — View run

---

#216 is open and unmerged (mergedAt is null), and it isn't a draft. I fetched it live just now. Its head is still 1916f9a8cd4a85e0513f17570ff57dc45fdd757b, the commit I reviewed, so the earlier verdict still applies.

Verdict

Ready for merge

Structured Review Data (JSON)

{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "1916f9a8cd4a85e0513f17570ff57dc45fdd757b",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Traced theme-picker.html and qwt-reveal-toggle.html: KEY switched to lds-theme with a legacy mln-theme read fallback, writes use the new key, and no other consumers of the old key exist outside the submodule.",
  "holistic_assessment": "The change is scoped to the storage-key rename, docs match behavior, existing user preferences are preserved, and there are no dependency, build artifact or math concerns."
}

Reviewed commit: 1916f9a

[github-actions]

💰 Cost: $0.2099 (review) — run

[github-actions]

PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/qwt/pr-preview/pr-216/

_{Built to branch gh-pages at 2026-11-12 21:34 UTC.}

[d-morrison]

🤖 Antigravity agent report

Cross-harness review (Gemini 3.8 Flash (Medium) via Antigravity agy, read-only plan mode) at 1916f9a

Flash saw the PR diff (CLAUDE.md, theme-picker.html, qwt-reveal-toggle.html; +14/-10) and file comparisons I made by fetching the sibling repos' copies; it ran nothing.
Facts I verified: after this PR qwt's theme-picker.html is byte-identical to the copies in lds, pds and sds (3076 bytes), while mcs and psw hold a different 3129-byte copy and mds and psc an older 2978-byte copy; qwt's qwt-reveal-toggle.html at this head matches pds's (3686 bytes) but differs from sds (3684), mcs (3726), psw (3725), mds and psc (3586), and lds does not vendor it.

Verdict: CLEAN. Flash found nothing blocking.
It found the migration logic correct (lds-theme read first, fallback to mln-theme, writes the new key, the legacy key kept so no saved theme is lost or flipped), the two files in agreement, the CLAUDE.md change accurate, no behavior change beyond the key, and no rendering risk.
On the weekly sync it read the lds, pds and sds matches as the intended effect and the other differences as stale or local variants for the sync PRs to reconcile; I have not looked at what those remaining diffs contain.

Posted by Claude Code (AI agent) --- not written by a human.