Skip to content

Install Racket for the Claude review job - #153

Merged
dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-2wtrwq-review-racket
Nov 11, 2026
Merged

dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-2wtrwq-review-racket

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Supports #131; it does not close it, and GitHub has no PR-to-issue relationship other than a closing keyword (#150 carries that).

Why

Chapters now run their Racket examples at render time (#139 and the chapter PRs stacked on it).
The automatic reviewer checks each chunk's output by running it, and so far it has installed racket by hand in each review.
The review of #140 suggested installing it through the reusable workflow's apt-packages input instead, which exists on Morrison-Lab/gha's claude-code-review.yml@v2.

What

One line in .github/workflows/claude-code-review.yml: apt-packages: racket.

This is its own PR because the reusable workflow skips reviewing a PR that edits this file, so folding it into #139 would have left #139 without a review.
It does not depend on #139 and can merge in any order.

Checks

  • The workflow file parses as YAML.
  • apt-packages is a declared input of Morrison-Lab/gha/.github/workflows/claude-code-review.yml@v2, read from that file.

Generated by Claude Code

Pages now run Racket code at render time (mcs#131), and the reviewer
checks each chunk's output by running it. Without racket installed it
has to apt-get install it by hand in every review, which the #140
review called out. The reusable workflow's apt-packages input does
this once, before the review starts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrEUFVHj2qKjKncHg77
Copilot AI balanced review requested due to automatic review settings November 11, 2026 10:30
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


This is a minimal, well-scoped, single-line change. It's exactly what the PR description promises, the referenced input (apt-packages) genuinely exists on the pinned @v2 tag with matching semantics, racket is a real installable apt package, the resulting YAML parses correctly, and the PR is directly validated by a prior review's explicit follow-up request. No CLAUDE.md violations apply here (no R code, no Quarto prose, no new top-level dependency — this just lets CI install a package already relied on by merged chapter content). Nothing else in the diff to flag.

Verdict

Ready for merge — the one-line apt-packages: racket addition to .github/workflows/claude-code-review.yml is verified correct: the input exists and behaves as described on Morrison-Lab/gha@v2, racket is a valid Ubuntu apt package, the resulting YAML parses, and the change is exactly the follow-up previously requested in the #140 review. No findings.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "4a16e34ea78318789886a5cd4bdcaaa88957a018",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The single added line in .github/workflows/claude-code-review.yml sets apt-packages: racket, which was validated against the pinned Morrison-Lab/gha@v2 reusable workflow and parses as valid YAML with no structural regressions.",
  "holistic_assessment": "Scope matches the PR description exactly, satisfies the follow-up requested during the prior #140 review, introduces no new top-level dependency beyond the already-adopted Racket toolchain, and requires no further validation since CI apt-get installation is the only integration point touched."
}

Reviewed commit: 4a16e34

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3554 (review) — run

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the workflow change that makes Racket available to the automatic reviewer.

No open issues 🎉

What changed in this PR

Makes Racket available to the automatic Claude reviewer so it can execute chapter examples and verify their output, supporting the render-time execution work in #131.

Changes:

  • Adds apt-packages: racket to the reusable review workflow’s inputs, replacing manual installation during reviews.
File Description
.github/​workflows/​claude-code-review.yml Requests Racket installation for the Claude review job.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mcs/pr-preview/pr-153/

Built to branch gh-pages at 2026-11-11 10:49 UTC.

@dem-extra1
dem-extra1 merged commit 52c0929 into main Nov 11, 2026
41 checks passed
@dem-extra1
dem-extra1 deleted the claude/project-thread-2wtrwq-review-racket branch November 11, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants