Repository navigation
Install Racket for the Claude review job - #153
Conversation
Pages now run Racket code at render time (mcs#131), and the reviewer checks each chunk's output by running it. Without racket installed it has to apt-get install it by hand in every review, which the #140 review called out. The reusable workflow's apt-packages input does this once, before the review starts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrEUFVHj2qKjKncHg77
|
Claude finished review — View run This is a minimal, well-scoped, single-line change. It's exactly what the PR description promises, the referenced input ( VerdictReady for merge — the one-line Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "4a16e34ea78318789886a5cd4bdcaaa88957a018",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The single added line in .github/workflows/claude-code-review.yml sets apt-packages: racket, which was validated against the pinned Morrison-Lab/gha@v2 reusable workflow and parses as valid YAML with no structural regressions.",
"holistic_assessment": "Scope matches the PR description exactly, satisfies the follow-up requested during the prior #140 review, introduces no new top-level dependency beyond the already-adopted Racket toolchain, and requires no further validation since CI apt-get installation is the only integration point touched."
}Reviewed commit: 4a16e34 |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the workflow change that makes Racket available to the automatic reviewer.
No open issues 🎉
What changed in this PR
Makes Racket available to the automatic Claude reviewer so it can execute chapter examples and verify their output, supporting the render-time execution work in #131.
Changes:
- Adds
apt-packages: racketto the reusable review workflow’s inputs, replacing manual installation during reviews.
| File | Description |
|---|---|
.github/workflows/claude-code-review.yml |
Requests Racket installation for the Claude review job. |
Review effort: Balanced
Built to branch |
Requested by Ezra · project thread
Supports #131; it does not close it, and GitHub has no PR-to-issue relationship other than a closing keyword (#150 carries that).
Why
Chapters now run their Racket examples at render time (#139 and the chapter PRs stacked on it).
The automatic reviewer checks each chunk's output by running it, and so far it has installed
racketby hand in each review.The review of #140 suggested installing it through the reusable workflow's
apt-packagesinput instead, which exists onMorrison-Lab/gha'sclaude-code-review.yml@v2.What
One line in
.github/workflows/claude-code-review.yml:apt-packages: racket.This is its own PR because the reusable workflow skips reviewing a PR that edits this file, so folding it into #139 would have left #139 without a review.
It does not depend on #139 and can merge in any order.
Checks
apt-packagesis a declared input ofMorrison-Lab/gha/.github/workflows/claude-code-review.yml@v2, read from that file.Generated by Claude Code