fix(kimi-code): resolve Windows EINVAL in dev.mjs and reduce thinking…#235
fix(kimi-code): resolve Windows EINVAL in dev.mjs and reduce thinking…#235Bronya0 wants to merge 1 commit into
Conversation
… flush rate - Add shell:true for Windows in dev.mjs to fix spawn EINVAL - Suppress DEP0190 deprecation warning for dev script - Increase STREAMING_UI_FLUSH_MS from 50ms to 200ms to prevent eye-straining flicker during thinking streaming
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45c20c07c7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| cwd: APP_ROOT, | ||
| env, | ||
| stdio: 'inherit', | ||
| shell: useShell, |
There was a problem hiding this comment.
On Windows this switches the dev launcher to shell: true while still passing the hard-coded tsx flags and forwarded cliArgs as an args array. Node 24's DEP0190 warning for this exact mode says the arguments are not escaped and are only concatenated, so common invocations such as pnpm dev -- --prompt "hello world" or any option value containing spaces/metacharacters can be split or interpreted by cmd.exe before reaching the CLI. Use a Windows-safe executable path or quote/escape the command instead of forwarding user args through the shell.
Useful? React with 👍 / 👎.
1 participant
… flush rate
Related Issue
Resolve #(issue_number)
Problem
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.