fix(cli): clarify permission mode approval behavior#1877
Open
whatevertogo wants to merge 3 commits into
Open
Conversation
Distinguish YOLO regular-tool approvals from exceptional prompts and describe Auto as unattended across command help, selectors, notices, and replay. Add regression coverage for the permission order and user-visible copy. Refs MoonshotAI#1859, MoonshotAI#1866, MoonshotAI#1874
Keep the updated permission descriptions in the existing one-line call and property layout without applying unrelated whole-file formatting.
🦋 Changeset detectedLatest commit: 0b56643 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Keep the existing behavior-level coverage without pinning user-facing permission descriptions verbatim in multiple test suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1866
Closes #1874
Addresses #1859 — clarifies the semantics without renaming the shipped modes.
Problem
The permission engines implement an increasing autonomy order of
manual < yolo < auto:The copy shipped across the CLI and TUI used absolute or incomplete descriptions such as "Approve every action yourself", "Tool actions auto-approved", and "All actions auto-approved". That made the distinction unclear and contributed to the confusion reported in #1859, #1866, and #1874.
Issue #1859 suggests swapping or renaming the modes. This PR takes the compatibility-preserving approach instead: it keeps the shipped names, command semantics, persisted values, and permission-engine behavior unchanged, while making the user-facing contract explicit.
This is a follow-up to #1867, which first aligned the broad permission-mode descriptions.
What changed
/permissionselector, slash-command autocomplete,/autoand/yolonotices, and session replay.@moonshot-ai/kimi-code, as required for this user-visible CLI/TUI change.File change summary
.changeset/clarify-permission-mode-copy.mdapps/kimi-code/src/cli/commands.ts,src/tui/commands/config.ts,src/tui/commands/registry.tssrc/tui/components/dialogs/permission-selector.ts,src/tui/controllers/session-replay.tsVerification
apps/kimi-codeTypeScript typecheck passed.git diff --check origin/main...HEADpassed.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. The current docs already describe the engine semantics correctly; this PR only makes existing CLI/TUI copy more precise.