fix(agent-core-v2): follow symlinks in read and media tools#1842
Closed
7Sageer wants to merge 1 commit into
Closed
fix(agent-core-v2): follow symlinks in read and media tools#18427Sageer wants to merge 1 commit into
7Sageer wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 25f8967 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
5 tasks
Collaborator
Author
|
Superseded by #1843, which fixes the same class of symlink issues at the semantics level (stat now follows symlinks by default), making these per-call-site fixes unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Follow-up to #1840 (same root cause; that PR only covered AGENTS.md loading before it was merged).
Problem
The v2 engine's filesystem
statuseslstatsemantics, so symbolic links are not counted as regular files. Two user-visible consequences in the web backend (installing files as symlinks is a common dotfiles setup):Readtool rejects symlinked files with"<path>" is not a file.ReadMediaFilesize checks measure the symlink itself instead of its target, so oversized media behind a symlink bypasses the size limit.The CLI (v1 engine) follows symlinks and handles such files correctly, so CLI and web behavior diverge.
What changed
ReadandReadMediaFilenow stat with thefollowSymlinksoption introduced in fix(agent-core-v2): follow symlinks when loading AGENTS.md and reading files #1840, matching the v1 CLI behavior.Readstats withfollowSymlinks.Skill discovery and MCP config loading were audited for the same problem and are not affected: they use
node:fsdirectly, which already follows symlinks.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.