feat(tools): make key argument width adaptive to terminal size#885
Open
zdyxry wants to merge 1 commit intoMoonshotAI:mainfrom
Open
feat(tools): make key argument width adaptive to terminal size#885zdyxry wants to merge 1 commit intoMoonshotAI:mainfrom
zdyxry wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the key-argument display width adaptive to the current terminal size, improving the readability of tool call summaries in the CLI.
Changes:
- Introduced
_get_key_argument_width()inkimi_cli.toolsto compute a dynamic key-argument width based onshutil.get_terminal_size, with sensible min/max bounds and error handling. - Extended
extract_key_argument()with an optional, keyword-onlywidthparameter and wired it to use_get_key_argument_width()whenwidthis not provided. - Added a dedicated test module
tests/tools/test_extract_key_argument.pycovering_get_key_argument_width()behavior across terminal widths and validating extraction/truncation logic for multiple tools and error cases.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/kimi_cli/tools/init.py | Adds adaptive key-argument width calculation and integrates it into extract_key_argument while preserving existing behavior and call sites. |
| tests/tools/test_extract_key_argument.py | Provides focused unit tests for the new width helper and extract_key_argument across various tools, terminal sizes, and failure scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#799
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.