Skip to content

Create kimi-cli#2516

Closed
owndaboubi1993-cyber wants to merge 1 commit into
MoonshotAI:mainfrom
owndaboubi1993-cyber:patch-1
Closed

Create kimi-cli#2516
owndaboubi1993-cyber wants to merge 1 commit into
MoonshotAI:mainfrom
owndaboubi1993-cyber:patch-1

Conversation

@owndaboubi1993-cyber

@owndaboubi1993-cyber owndaboubi1993-cyber commented Jul 19, 2026

Copy link
Copy Markdown

skills n plugins

Related Issue

Resolve #(issue_number)

Description

Checklist

  • I have read the CONTRIBUTING document.
  • I have linked the related issue, if any.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run make gen-changelog to update the changelog.
  • I have run make gen-docs to update the user documentation.

Open in Devin Review

skills n plugins

Signed-off-by: Own Ghazi Mohammad Al-Daboubi <owndaboubi1993@gmail.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread MoonshotAI/kimi-cli
// Conceptual plugin pseudocode
async function kimiPush(message = "kimi-cli") {
await exec("git add .");
await exec(`git commit -m "${message}"`);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟥 Command injection via unsanitized commit message interpolation

The kimiPush function interpolates the caller-supplied message directly into a shell command string (git commit -m "${message}" at MoonshotAI/kimi-cli:4) and passes it to exec. A message containing shell metacharacters (e.g. "; rm -rf / # or $(...)) breaks out of the quoted argument and executes arbitrary commands.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant