Create kimi-cli#2516
Closed
owndaboubi1993-cyber wants to merge 1 commit into
Closed
Conversation
skills n plugins Signed-off-by: Own Ghazi Mohammad Al-Daboubi <owndaboubi1993@gmail.com>
| // Conceptual plugin pseudocode | ||
| async function kimiPush(message = "kimi-cli") { | ||
| await exec("git add ."); | ||
| await exec(`git commit -m "${message}"`); |
Contributor
There was a problem hiding this comment.
🟥 Command injection via unsanitized commit message interpolation
The kimiPush function interpolates the caller-supplied message directly into a shell command string (git commit -m "${message}" at MoonshotAI/kimi-cli:4) and passes it to exec. A message containing shell metacharacters (e.g. "; rm -rf / # or $(...)) breaks out of the quoted argument and executes arbitrary commands.
Was this helpful? React with 👍 or 👎 to provide feedback.
This was referenced Jul 19, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skills n plugins
Related Issue
Resolve #(issue_number)
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.