fix(glob): prevent path traversal via '..' in glob patterns#1027
Open
hsyodyssey wants to merge 1 commit intoMoonshotAI:mainfrom
Open
fix(glob): prevent path traversal via '..' in glob patterns#1027hsyodyssey wants to merge 1 commit intoMoonshotAI:mainfrom
hsyodyssey wants to merge 1 commit intoMoonshotAI:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
N/A - Security fix for path traversal vulnerability in Glob tool
Description
This PR fixes a path traversal vulnerability in the
Globtool by rejecting patterns containing...Problem
The
Globtool did not validate patterns for..sequences, allowing access to files outside the working directory (e.g.,../.env,../.. /**/*.key).Solution
Added validation in
_validate_pattern()to detect and reject patterns containing path traversal sequences.Changes:
src/kimi_cli/tools/file/glob.py: Added..check in_validate_pattern()methodTesting
..are rejected with error message*.py,src/**/*.js) still work correctlyChecklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.