docs(coins): point the icon readme at the embedded loader - #692
Merged
Merged
Conversation
The readme named a loader path that no longer exists and described the icons as a runtime drop-in. The set is embedded from media/coin_icons.rs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
assets/coins/README.mdnamedcrates/moon-ui-gpui/src/coin_icons.rsand said the icons are loaded at runtime by dropping{symbol}.pnginto that folder. The loader iscrates/moon-ui-gpui/src/media/coin_icons.rs: it embeds the set withinclude_dir, and the Assets window draws those icons in the positions table and in the Spot, Futures, and Quarterly wallet containers. Lookup strips a literal1000prefix, so1000PEPEusespepe.png.Review dropped one sentence. A PNG beside the executable does not replace the embedded icon while the working directory already has an
assets/coinsdirectory:asset_dirreturns the working-directory folder first and only then looks beside the executable.How to verify
Read against
crates/moon-ui-gpui/src/media/coin_icons.rs,crates/moon-ui-gpui/src/media/mod.rs(asset_dir),crates/moon-ui-gpui/src/panels/assets/table.rs(coin_cell),crates/moon-ui-gpui/src/panels/assets/wallets.rs, and the Assets module header. A clean-context review compared the new text with those sources and disputed only the sentence removed above. Markdown only.Verified the
moon-ui-gpuicoin-icon path. This run did not opendocs/ARCHITECTURE.md.