chore(deps): re-pin MoonUI to the tooltip paint-order fix - #654
Merged
Merged
Conversation
MoonUI 1767a249 raises the managed tooltip overlay above the popover and dropdown band, so a tooltip on a button inside a MoonPopover is visible again (Moonbot-Tech/MoonUI#78, this repo's #628). Hand-edited: the 23 MoonUI revision lines only, proven by `cargo fetch --locked` returning 0. `cargo update -p` was not used — it re-resolves unrelated dependency edges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #628 on this side.
MoonUI
1767a249(Moonbot-Tech/MoonUI#78) raises the managed tooltip overlay above the popoverand dropdown band. Until this repo pins that revision, a tooltip on a glyph button inside any
MoonPopover— every chart settings popup — still paints underneath the popup and is invisible.Only the 23 MoonUI revision lines in
Cargo.lockchanged; nothing else in the graph moved. Theedit was made by hand rather than with
cargo update -p, which re-resolves unrelated dependencyedges even when told to touch one crate.
How to verify
cargo fetch --lockedreturns 0 — the lock is valid against the manifests, which is the wholecontract this commit has to satisfy. CI runs the same check first in every compiling job.
hover a glyph button inside it. The tooltip appears on top of the popup. Confirmed on the
Windows build before this PR was opened.