Skip to content

Remove AST Access from ConnectionCoCos #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MKZaito wants to merge 2 commits into
base: release/7.8.x
Choose a base branch
from
Draft

Remove AST Access from ConnectionCoCos #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c90e5eb
remove AST Access
MKZaito Mar 23, 2026
fde5a9b
finalize SymbolTable in Tests
MKZaito Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 3 additions & 32 deletions ...ain/java/de/monticore/lang/sysmlv2/cocos/ParentComponentInputConnectionDirectionCoCo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
/* (c) https://github.com/MontiCore/monticore */
package de.monticore.lang.sysmlv2.cocos;

import de.monticore.lang.sysmlbasis._ast.ASTModifier;
import de.monticore.lang.sysmlbasis._ast.ASTSysMLTyping;
import de.monticore.lang.sysmlparts._ast.ASTAttributeUsage;
import de.monticore.lang.sysmlparts._ast.ASTConnectionUsage;
import de.monticore.lang.sysmlparts._cocos.SysMLPartsASTConnectionUsageCoCo;
import de.monticore.lang.sysmlparts._symboltable.ISysMLPartsScope;
Expand Down Expand Up @@ -180,41 +177,15 @@ protected PortUsageSymbol resolvePortOfSubPart(ISysMLPartsScope scope,
return null;
}

/** Extract modifiers from PortUsageSymbol */
protected ASTModifier getModifiersFromPortUsageSymbol(PortUsageSymbol symbol) {
ASTAttributeUsage portAttributeUsageAST = (ASTAttributeUsage)
symbol.getAstNode()
.getPortDefs()
.get(0)
.getSysMLElementList()
.get(0);
return portAttributeUsageAST.getModifier();
}

protected boolean portIsInput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
boolean portIsInAndNotConjugated = mods.isIn() && !portIsConjugated(symbol);
boolean portIsOutAndConjugated = mods.isOut() && portIsConjugated(symbol);
return (portIsInAndNotConjugated || portIsOutAndConjugated);
return !symbol.getInputAttributes().isEmpty();
}

protected boolean portIsOutput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
boolean portIsOutAndNotConjugated = mods.isOut() && !portIsConjugated(symbol);
boolean portIsInAndConjugated = mods.isIn() && portIsConjugated(symbol);
return (portIsOutAndNotConjugated || portIsInAndConjugated);
return !symbol.getOutputAttributes().isEmpty();
}

protected boolean portIsInOutput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
return mods.isInout();
}

protected boolean portIsConjugated(PortUsageSymbol symbol) {
return
((ASTSysMLTyping) symbol
.getAstNode()
.getSpecialization(0))
.isConjugated();
return portIsInput(symbol) && portIsOutput(symbol);
}
}
35 changes: 3 additions & 32 deletions .../main/java/de/monticore/lang/sysmlv2/cocos/SubcomponentOutputConnectionDirectionCoCo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
/* (c) https://github.com/MontiCore/monticore */
package de.monticore.lang.sysmlv2.cocos;

import de.monticore.lang.sysmlbasis._ast.ASTModifier;
import de.monticore.lang.sysmlbasis._ast.ASTEndpoint;
import de.monticore.lang.sysmlbasis._ast.ASTSysMLTyping;
import de.monticore.lang.sysmlparts._ast.ASTAttributeUsage;
import de.monticore.lang.sysmlparts._ast.ASTConnectionUsage;
import de.monticore.lang.sysmlparts._cocos.SysMLPartsASTConnectionUsageCoCo;
import de.monticore.lang.sysmlparts._symboltable.*;
Expand Down Expand Up @@ -167,41 +164,15 @@ protected PortUsageSymbol resolvePortOfSubPart(ISysMLPartsScope scope,
return null;
}

/** Extract modifiers from PortUsageSymbol */
protected ASTModifier getModifiersFromPortUsageSymbol(PortUsageSymbol symbol) {
ASTAttributeUsage portAttributeUsageAST = (ASTAttributeUsage)
symbol.getAstNode()
.getPortDefs()
.get(0)
.getSysMLElementList()
.get(0);
return portAttributeUsageAST.getModifier();
}

protected boolean portIsInput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
boolean portIsInAndNotConjugated = mods.isIn() && !portIsConjugated(symbol);
boolean portIsOutAndConjugated = mods.isOut() && portIsConjugated(symbol);
return (portIsInAndNotConjugated || portIsOutAndConjugated);
return !symbol.getInputAttributes().isEmpty();
}

protected boolean portIsOutput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
boolean portIsOutAndNotConjugated = mods.isOut() && !portIsConjugated(symbol);
boolean portIsInAndConjugated = mods.isIn() && portIsConjugated(symbol);
return (portIsOutAndNotConjugated || portIsInAndConjugated);
return !symbol.getOutputAttributes().isEmpty();
}

protected boolean portIsInOutput(PortUsageSymbol symbol) {
ASTModifier mods = getModifiersFromPortUsageSymbol(symbol);
return mods.isInout();
}

protected boolean portIsConjugated(PortUsageSymbol symbol) {
return
((ASTSysMLTyping) symbol
.getAstNode()
.getSpecialization(0))
.isConjugated();
return portIsInput(symbol) && portIsOutput(symbol);
}
}
1 change: 1 addition & 0 deletions language/src/test/java/cocos/ParentComponentInputConnectionDirectionCoCoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ private ISysMLv2ArtifactScope createSt(ASTSysMLModel ast) {
var tool = new SysMLv2Tool();
var scope = tool.createSymbolTable(ast);
tool.completeSymbolTable(ast);
tool.finalizeSymbolTable(ast);
return scope;
}

Expand Down
1 change: 1 addition & 0 deletions language/src/test/java/cocos/SubcomponentOutputConnectionDirectionCoCoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ private ISysMLv2ArtifactScope createSt(ASTSysMLModel ast) {
var tool = new SysMLv2Tool();
var scope = tool.createSymbolTable(ast);
tool.completeSymbolTable(ast);
tool.finalizeSymbolTable(ast);
return scope;
}

Expand Down
Loading