[201_2791] Fix tab cycling issue for stroke alphabet characters#2838
Open
Gitjay11 wants to merge 2 commits intoMoganLab:mainfrom
Open
[201_2791] Fix tab cycling issue for stroke alphabet characters#2838Gitjay11 wants to merge 2 commits intoMoganLab:mainfrom
Gitjay11 wants to merge 2 commits intoMoganLab:mainfrom
Conversation
Contributor
|
This fix is wrong. |
Contributor
Author
|
hi @da-liii , can you review it now? |
d459d2e to
30fbebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026/02/22 Fix Tab Cycling for Stroke Alphabet Characters.
What
Added
varcontinuation chains for stroke alphabet characters inmath-kbd.scm.Why
To resolve issue #2791.
The tab cycling UI only displays cyclic completions for characters when they are defined through the
varcontinuation chain from a base keystroke. Since only- varcombinations were added previously, they were missing from the tab cycling menu.How
Added
("<base> var var ..." "<#unicode>")entries corresponding to the previously added- varentries inTeXmacs/progs/math/math-kbd.scm. Also fixed minor trailing space typos in existing mappings liked - var.How to test
kthen-, it should become a strokek(<#A741>).kthen pressTab3 times. It should correctly show the strokekcharacter (<#A741>) in the footer and cycle to it.c,d,f,l,o,p,sand uppercaseC,D,F,K,L,O,P,S.