[202_2787] Fix inconsistent focus toolbar numbering button in tables#2833
Open
Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Open
[202_2787] Fix inconsistent focus toolbar numbering button in tables#2833Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Gitjay11 wants to merge 1 commit intoMoganLab:mainfrom
Conversation
Contributor
Author
|
Hi @da-liii @wumoin @SaidealemEksan @Yuki-Nagori , I’ve submitted this PR. Could you please take a moment to review it when you have time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modified [TeXmacs/progs/table/table-menu.scm] to extend the definition of
numbered-context?andnumbered-numbered?.Why
Inside tables (
tabular,tformat, etc.), thenumbered-context?predicate returned#fforcellandrowtags, causing the numbering/unnumbering buttons in the focus toolbar to be disabled or hidden. This fixes issue #2787.How
By recursively checking parent nodes, table cells can now inherit the numbering properties of the enclosing
small-tableorbig-table. Verification: Insert a small table, click inside a cell, and the numbering button in the focus toolbar should become active and toggle numbering correctly.