Fix crash when deleting image while selection tool is active#160
Open
Slashxdd wants to merge 1 commit intoModuleArt:feature/new-webp-decoderfrom
Open
Fix crash when deleting image while selection tool is active#160Slashxdd wants to merge 1 commit intoModuleArt:feature/new-webp-decoderfrom
Slashxdd wants to merge 1 commit intoModuleArt:feature/new-webp-decoderfrom
Conversation
Resolves ModuleArt#92: pressing Delete with the selection tool open caused a NullReferenceException in GetSelectionRect() because SelForm_SizeChanged fired during selForm disposal while originalImage was already null. The deletion flow sets originalImage = null, then calls NextFile() -> openImage() -> selectionBtn.Checked = false -> selForm.Dispose(). During disposal the SizeChanged event fires, SelForm_SizeChanged calls GetSelectionRect() which dereferences originalImage.Width -> crash. Fix: guard SelForm_SizeChanged with an originalImage null check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
6fdbb37 to
d4a8cf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
Root cause
NullReferenceExceptioninGetSelectionRect()atoriginalImage.Width.The exact crash chain:
selForm != null)deleteButton_Clickfires (Delete is bound asShortcutKeysondeleteBtn)deleteButton_Clickdisposes the image and setsoriginalImage = nullNextFile()βOpenFile()βopenImage()openImage(),selectionBtn.Checked = falsefiresselectionBtn_CheckedChangedβselForm.Dispose()SizeChangedevent onselFormSelForm_SizeChangedcallsGetSelectionRect()GetSelectionRect()accessesoriginalImage.WidthβoriginalImageis null β crashFix
One-line null guard at the entry of
SelForm_SizeChanged:GetSelectionRect()is only meaningful when an image is loaded, so returning early whenoriginalImageis null is always correct.