-
Notifications
You must be signed in to change notification settings - Fork 335
Support GLM-5.2 (glm_moe_dsa, DeepSeek-V3.2-style DSA MoE) #1370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sufubao
wants to merge
8
commits into
ModelTC:main
Choose a base branch
from
sufubao:support_glm52
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
703de08
support glm52
sufubao 2654a70
fix(nsa): correct fp8 DSA FlashMLA prefill/decode kernel contract
sufubao b0ce5b3
cleanup(mtp): drop dead class-name list in is_mtp_draft_model predicate
sufubao 115ca55
cleanup(glm5_2): fix contradictory rope_theta default
sufubao 7e3dde2
perf(glm5_2): add fused_add_rmsnorm (residual-add + RMSNorm in one ke…
sufubao 94c8b20
perf(glm5_2): fold attn-output all-reduce into the residual + ffn RMS…
sufubao d46cbdd
perf(moe): fuse silu_and_mul with the down-proj per-token-group fp8 q…
sufubao d94e6bb
docs(glm5_2): add GLM-5.2 to the supported models list
sufubao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
_nsa_decode_att,topk_mem_indicesis passed directly toflash_mla_with_kvcacheasindices=topk_mem_indices.to(dtype=torch.int32).However,
topk_mem_indicesis a 2D tensor of shape[batch_size, topk], whereasflash_mla_with_kvcacheexpectsindicesto be a 3D tensor of shape[batch_size, q_seqlen, topk](whereq_seqlen = 1in decode). Passing a 2D tensor can cause shape mismatch errors or silent correctness issues in the kernel.We should unsqueeze
indicesto 3D if it is 2D, similar to how it is handled in_nsa_prefill_att.