auto-triage: catch TypeError from malformed RAST server error response#3
Draft
jplfaria wants to merge 2 commits into
Draft
auto-triage: catch TypeError from malformed RAST server error response#3jplfaria wants to merge 2 commits into
jplfaria wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ModelSEED/modelseed-api-ops#19
Root cause
When the RAST annotation server (
tutorial.theseed.org) returns an error response whereerr["error"]is a plain string instead of the expected{"code":..., "message":...}dict, therpcclient.pyline:raises
TypeError: ServerError() argument after ** must be a mapping, not str.This
TypeErrorescapesgenome_annotator.py'sexcept Exception as exc:block because:is_transientisFalse(no HTTP status codes in the TypeError message)TypeError, giving Celery workers a misleading internal Python errorFix
Add a
except TypeError as exc:handler before the generalexcept Exceptioninannotate_fasta()'s retry loop. It converts the rawTypeErrorinto a descriptiveRuntimeErrorso the Celery failure log and job error field show a meaningful message.Files changed
src/modelseed_api/services/genome_annotator.py: Add TypeError handlertests/unit/test_genome_annotator.py: AddTestAnnotateFastaTypeErrorHandlingregression testTest plan
test_rpc_typeerror_wraps_to_runtimeerrorpasses (mocks RPCClient to raise TypeError, verifies RuntimeError with "malformed error response" is raised)