Skip to content

Conversation

@jiqing-feng
Copy link
Collaborator

This PR fix:

  1. When device_map is auto, we shoud return the accelerator type instead of None, which will auto select cuda.
  2. Fix the linear mode (train or inference) for the very first time and never change it later.

Hi @Qubitium . Would you please review this PR? Thanks!

The reason I want to make this change is because of the peft test failed: test_adalora_causalLM

@jiqing-feng jiqing-feng marked this pull request as draft January 7, 2026 08:31
@jiqing-feng
Copy link
Collaborator Author

Convert to draft for more checks.

@jiqing-feng jiqing-feng marked this pull request as ready for review January 7, 2026 08:53
@jiqing-feng
Copy link
Collaborator Author

jiqing-feng commented Jan 7, 2026

Hi @Qubitium . There are too many tests in the repo. What kind of tests should I run?

@jiqing-feng jiqing-feng requested a review from Qubitium January 7, 2026 08:57
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
@Qubitium
Copy link
Collaborator

Qubitium commented Jan 8, 2026

@jiqing-feng LGTM. Thanks for the fix! We will add a unit test to check to validate the device_map for future regression. I don't think we have one to only test device_map normalization.

@Qubitium Qubitium merged commit db0cc2f into ModelCloud:main Jan 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants