Skip to content

feat: seed api.announcements notification type#1741

Open
cka-y wants to merge 2 commits into
mainfrom
feat/1729
Open

feat: seed api.announcements notification type#1741
cka-y wants to merge 2 commits into
mainfrom
feat/1729

Conversation

@cka-y

@cka-y cka-y commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary:
This pull request introduces a new notification type for API announcements and ensures that existing users who have opted in are properly subscribed. The main changes are:

  • Created liquibase/changes_user/feat_1729.sql to:
    • Seed the notification_type table with a new 'api.announcements' type.
    • Backfill the notification_subscription table for users already opted in, ensuring no duplicate subscriptions are created.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y marked this pull request as ready for review June 15, 2026 19:27
@cka-y cka-y linked an issue Jun 15, 2026 that may be closed by this pull request
2 tasks
@cka-y cka-y marked this pull request as draft June 15, 2026 19:29
@cka-y cka-y marked this pull request as ready for review June 15, 2026 20:07
FROM app_user u
WHERE u.is_registered_to_receive_api_announcements
AND NOT EXISTS (
SELECT 1 FROM notification_subscription s

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove the is_registered_to_receive_api_announcements column if it's part of another issue? We will also need to modify the user migration task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seed api.announcements notification type

2 participants