feat: change tracker email template#1738
Open
Alessandro100 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Jinja2 HTML email template intended to format GTFS change-tracker notifications (diff summary + breaking/suspicious changes + feature and validation diffs) for eventual outbound email delivery.
Changes:
- Introduces
change_tracker_email.html.jinja2with a multi-feed table-of-contents and per-feed sections. - Adds rendering for diff summary stats, breaking/suspicious change callouts, feature changes, and validation report diffs.
- Includes email-client specific markup (e.g., Outlook/VML button) and responsive styles.
Comment on lines
+333
to
+334
| <a | ||
| href="#feed-{{ loop.index }}" |
| {# Anchor target for TOC links #} | ||
| <tr> | ||
| <td> | ||
| <a name="feed-{{ loop.index }}" id="feed-{{ loop.index }}" style="display: block; font-size: 0; line-height: 0;"> </a> |
| > | ||
| You're receiving this because you subscribe to updates for | ||
| {% if feeds | length == 1 %}this feed{% else %}these feeds{% endif %} on the Mobility Database.<br /> | ||
| © {{ notification_date.split(", ")[-1] }} MobilityData · Montréal, QC, Canada |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This email is still going to junk in Outlook which is relevant to: MobilityData/mobilitydatabase-web#121
closes: https://github.com/MobilityData/product-tasks/issues/198
Introduces the email template to use for notification changes based on the gtfs diff schema. Also includes features not included in the schema like: validation diff, feature diff, breaking changes, and suspicious changes
Expected behavior:
When we are ready to send emails regarding the gtfs change notifications, this email template will format it nicely
Testing tips:
At the root of the mobility-feeds-api run
which will open up a preview. You can modify the values accordingly
Follow up tickets
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything