Repository navigation
Embed each concrete class in its leaf and type geometry arguments as Geo - #38
Merged
estebanzimanyi merged 1 commit intoNov 1, 2026
Merged
Conversation
A concrete <leaf><suffix> class embeds its leaf, as MEOS.NET's object layer makes the leaf its base: TGeomPointSeq embeds TGeomPoint and carries its methods, TPoint.AtGeom among them, where it embedded a bare handle and carried none. Witness: with no parent, a concrete class sat at depth 0, so TRGeometrySeqSet, whose catalog C type reads GSERIALIZED, was the shallowest class of that type and wrapped every geometry: 186 geometry arguments of the generated layer, the gs of TGeo.AtGeom among them, read *TRGeometrySeqSet; each now reads *Geo, and none reads *TRGeometrySeqSet. Measured: the 129 root examples pass under TZ=UTC, a temporal point sequence restricted to a polygon through the AtGeom it inherits, as the sequence set MEOS answers; the functions, types and root packages build with no go vet finding, and the parity tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A concrete class embeds its leaf, as MEOS.NET's object
layer makes the leaf its base: TGeomPointSeq embeds TGeomPoint and
carries its methods, TPoint.AtGeom among them, where it embedded a bare
handle and carried none.
Witness: with no parent, a concrete class sat at depth 0, so
TRGeometrySeqSet, whose catalog C type reads GSERIALIZED, was the
shallowest class of that type and wrapped every geometry: 186 geometry
arguments of the generated layer, the gs of TGeo.AtGeom among them,
read *TRGeometrySeqSet; each now reads *Geo, and none reads
*TRGeometrySeqSet.
Measured: the 129 root examples pass under TZ=UTC, a temporal point
sequence restricted to a polygon through the AtGeom it inherits, as the
sequence set MEOS answers; the functions, types and root packages build
with no go vet finding, and the parity tests pass.