Repository navigation
Apply the review follow-ups of PRs 33 and 34 - #36
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Applies the non-blocking review follow-ups of PRs #33 and #34, plus a guard for the docs domain. Every listed item is done; none was rejected.
graph-navigation.spec.ts: a right-click on a node leaves the selection unchanged and starts no layout transition or scroll change.isPrimaryTapmoved out ofopen-actions.tsintopointer.ts; the four importers follow. No behaviour change.test/helpers/source-blocks.tsbracket matching skips string and template literals and//and/* */comments, with unit tests intest/source-blocks.test.ts.const all = SKILL_NAMESalias is gone fromtest/install-skills.test.ts.docs/primitives.mdgains entries fortest/helpers/source-blocks.tsandtest/e2e/support/overview.ts(including.lt-side:not(.lt-overview)).test/docs-cname.test.tsassertingwebsite/public/CNAMEequals exactlydocs.thelantern.dev\n(the file decides the docs domain; it was dropped with the copy-text tests in PR chore: remove tests that assert only constants, copy text or CSS text #15 and is kept on purpose).Key files
test/e2e/graph-navigation.spec.ts— the right-click test. It fails when theisPrimaryTapguard is removed from the nodepointertaphandler (selected set changed), and passes with it.src/renderer/lib/lantern-pixi/pointer.ts— the movedisPrimaryTap.test/helpers/source-blocks.ts— literal- and comment-aware bracket matching; regex literals are not skipped (noted inprimitives.md).test/docs-cname.test.ts— fails with the CNAME content changed, passes restored.Before / after
Before:
isPrimaryTaplived inopen-actions.tsand every graphics file imported it from there; a}inside a string or comment unbalancedfunctionBody. After:import { isPrimaryTap } from './pointer', andfunctionBody("function f() { const s = '}'; }")returns the whole body.Verified with
pnpm run typecheck,pnpm run lint,pnpm test(the only failures seen were timeouts of install-skills and bundle tests under load, green when run on their own), andpnpm run test:graph:e2e: all green except the two@visualsnapshot specs, which fail identically (about 818k pixels differ) on pristine origin/main on this machine. Unreviewed fixes: 16b4b7c (regex note in primitives.md, after the review). Reviewer: merge-with-followups, BLOCKING 0. Lantern: 10 files re-mapped.Run cost