Skip to content

Apply the review follow-ups of PRs 33 and 34 - #36

Merged
gitsad merged 8 commits into
mainfrom
chore/review-followups-33-34
Nov 12, 2026
Merged

gitsad merged 8 commits into
mainfrom
chore/review-followups-33-34

Conversation

@gitsad

@gitsad gitsad commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What this changes

Applies the non-blocking review follow-ups of PRs #33 and #34, plus a guard for the docs domain. Every listed item is done; none was rejected.

  • A Playwright test in graph-navigation.spec.ts: a right-click on a node leaves the selection unchanged and starts no layout transition or scroll change.
  • isPrimaryTap moved out of open-actions.ts into pointer.ts; the four importers follow. No behaviour change.
  • test/helpers/source-blocks.ts bracket matching skips string and template literals and // and /* */ comments, with unit tests in test/source-blocks.test.ts.
  • The redundant const all = SKILL_NAMES alias is gone from test/install-skills.test.ts.
  • docs/primitives.md gains entries for test/helpers/source-blocks.ts and test/e2e/support/overview.ts (including .lt-side:not(.lt-overview)).
  • New test/docs-cname.test.ts asserting website/public/CNAME equals exactly docs.thelantern.dev\n (the file decides the docs domain; it was dropped with the copy-text tests in PR chore: remove tests that assert only constants, copy text or CSS text #15 and is kept on purpose).

Key files

  • test/e2e/graph-navigation.spec.ts — the right-click test. It fails when the isPrimaryTap guard is removed from the node pointertap handler (selected set changed), and passes with it.
  • src/renderer/lib/lantern-pixi/pointer.ts — the moved isPrimaryTap.
  • test/helpers/source-blocks.ts — literal- and comment-aware bracket matching; regex literals are not skipped (noted in primitives.md).
  • test/docs-cname.test.ts — fails with the CNAME content changed, passes restored.

Before / after

Before: isPrimaryTap lived in open-actions.ts and every graphics file imported it from there; a } inside a string or comment unbalanced functionBody. After: import { isPrimaryTap } from './pointer', and functionBody("function f() { const s = '}'; }") returns the whole body.

Verified with pnpm run typecheck, pnpm run lint, pnpm test (the only failures seen were timeouts of install-skills and bundle tests under load, green when run on their own), and pnpm run test:graph:e2e: all green except the two @visual snapshot specs, which fail identically (about 818k pixels differ) on pristine origin/main on this machine. Unreviewed fixes: 16b4b7c (regex note in primitives.md, after the review). Reviewer: merge-with-followups, BLOCKING 0. Lantern: 10 files re-mapped.

Run cost

agent model effort calls cache-read cache-write+input
lantern-delegate-medium sonnet 5.5 medium 79 14140501 600241
└ reviewer ×1 opus 5.5 medium 17 1218398 92127
total 96 15358899 692368

@gitsad
gitsad merged commit 2b08f80 into main Nov 12, 2026
16 checks passed
@gitsad
gitsad deleted the chore/review-followups-33-34 branch November 12, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant