Repository navigation
fix: type-check the e2e specs clean - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
pnpm run test:graph:typechecknow exits zero on the e2e specs (it failed with about 64 errors on main). The e2e tsconfig now picks up the ambient declarations the main tsconfig already had, and one spec uses the typed Electron API.Key files
test/e2e/tsconfig.json— includessrc/renderer/svg.d.tsandsrc/main/skill-scripts.d.ts, which declare the.svgimports and theskills/**/*.mjsmodules the e2e code reaches throughsrc/test/e2e/graph-pixi.spec.ts—getBitmap()(typedvoidin electron.d.ts, a deprecated alias) becomestoBitmap()(typedBuffer); the comparisons are unchangedBefore / after
Before:
pnpm run test:graph:typecheck-> TS7016 / TS2307 / TS2339 errors. After: exit 0, with no@ts-ignore,@ts-expect-error,as any,skipLibCheckor weakened strict flags.Verified with
pnpm run test:graph:typecheck,pnpm run typecheck,pnpm run lint,pnpm test, andplaywright test test/e2e/graph-pixi.spec.ts(14 passed). Unreviewed fixes: none.docs/primitives.mdnot edited: it lists no typecheck command to extend and another change owns it. Lantern: 2 files re-mapped.Run cost