Skip to content

fix: type-check the e2e specs clean - #35

Merged
gitsad merged 4 commits into
mainfrom
fix/e2e-typecheck-green
Nov 12, 2026
Merged

gitsad merged 4 commits into
mainfrom
fix/e2e-typecheck-green

Conversation

@gitsad

@gitsad gitsad commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

What this changes

pnpm run test:graph:typecheck now exits zero on the e2e specs (it failed with about 64 errors on main). The e2e tsconfig now picks up the ambient declarations the main tsconfig already had, and one spec uses the typed Electron API.

Key files

  • test/e2e/tsconfig.json — includes src/renderer/svg.d.ts and src/main/skill-scripts.d.ts, which declare the .svg imports and the skills/**/*.mjs modules the e2e code reaches through src/
  • test/e2e/graph-pixi.spec.ts — getBitmap() (typed void in electron.d.ts, a deprecated alias) becomes toBitmap() (typed Buffer); the comparisons are unchanged

Before / after

Before: pnpm run test:graph:typecheck -> TS7016 / TS2307 / TS2339 errors. After: exit 0, with no @ts-ignore, @ts-expect-error, as any, skipLibCheck or weakened strict flags.

Verified with pnpm run test:graph:typecheck, pnpm run typecheck, pnpm run lint, pnpm test, and playwright test test/e2e/graph-pixi.spec.ts (14 passed). Unreviewed fixes: none. docs/primitives.md not edited: it lists no typecheck command to extend and another change owns it. Lantern: 2 files re-mapped.

Run cost

agent model effort calls cache-read cache-write+input
lantern-delegate-medium sonnet 5.5 medium 72 9505578 178842
└ reviewer ×1 opus 5.5 medium 8 442901 77768
total 80 9948479 256610

@gitsad
gitsad merged commit 83ba1a0 into main Nov 12, 2026
14 checks passed
@gitsad
gitsad deleted the fix/e2e-typecheck-green branch November 12, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant