-
Notifications
You must be signed in to change notification settings - Fork 1
Add rule syncing to dual-tool agent configuration #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Miyamura80
wants to merge
2
commits into
main
Choose a base branch
from
feat/add-rule-syncing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ../../.claude/rules/codex-claude-sync.md | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| --- | ||
| name: new-agent-rule | ||
| description: Guide for creating a new path-scoped .claude/rules/ file with proper globs frontmatter and structure. | ||
| --- | ||
|
|
||
| # Creating a new path-scoped rule | ||
|
|
||
| Rules keep CLAUDE.md lean by scoping guidance to specific file paths. A rule only loads when the agent touches files matching its `globs:` pattern. | ||
|
|
||
| ## When to create a rule | ||
|
|
||
| - Guidance applies to a specific directory or file pattern, not the whole repo | ||
| - The guidance is long enough that embedding it in CLAUDE.md would bloat the file | ||
| - Multiple agents (or future tools) should pick up the same guidance automatically | ||
|
|
||
| ## Naming and location | ||
|
|
||
| - Source of truth: `.claude/rules/<name>.md` | ||
| - Name: `snake_case.md` describing the area (e.g., `api_routes.md`, `test_conventions.md`) | ||
| - Mirror: `.agents/rules/<name>.md` (symlink, created by `make sync-agent-config`) | ||
|
|
||
| ## Frontmatter format | ||
|
|
||
| Use `globs:` (NOT `paths:` -- it has known silent-failure bugs): | ||
|
|
||
| ```yaml | ||
| --- | ||
| description: One-line summary of what this rule covers | ||
| globs: | ||
| - "src/api/**" | ||
| - "tests/api/**" | ||
| --- | ||
| ``` | ||
|
|
||
| Pick the narrowest set of globs that covers the area. Overly broad globs waste context on unrelated tasks. | ||
|
|
||
| ## Workflow | ||
|
|
||
| 1. Check if CLAUDE.md already covers this guidance (if so, migrate it to a rule) | ||
| 2. Write `.claude/rules/<name>.md` with `globs:` frontmatter | ||
| 3. Run `make sync-agent-config` then `make ci` | ||
|
|
||
| ## Anti-patterns | ||
|
|
||
| - Forgetting `globs:` frontmatter (rule loads on every task, defeating the purpose) | ||
| - Restating what CLAUDE.md already says (keep rules additive, not duplicative) | ||
| - Using `paths:` instead of `globs:` (known silent-failure bugs in Claude) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. codex-claude-sync.md uses hyphen
📘 Rule violation✧ QualityAgent Prompt
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation toolsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Invalid. The filename
codex-claude-sync.mdfollows the cross-repo convention established in Edison-OS and all template repos. Renaming would break sync script assumptions and git history across repositories.