deposit arrives ealier than observer confirmations#25
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f51faca357
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
store/failed_deposit.go
Outdated
| query := fmt.Sprintf("SELECT %s FROM failed_deposits WHERE hash=?", strings.Join(failedDepositCols, ",")) | ||
| row := s.db.QueryRowContext(ctx, query, hash) |
There was a problem hiding this comment.
ReadFailedDepositByHash queries failed_deposits with QueryRowContext by hash, but hash is not unique (output_id is the primary key), so a single Solana signature can have multiple failed deposit rows (different deposit outputs). In that case confirmBurnRelatedSystemCall will only recover one row and mint only one reimbursement, leaving other failed deposits for the same transaction unprocessed forever; this should load and process all unhandled rows for the hash.
Useful? React with 👍 / 👎.
hundredark
force-pushed
the
bugfix/failed-deposit
branch
from
7264977 to
dc4167c
Compare
cedricfung
changed the title
2 participants
No description provided.