feat(web3): check Solana fee balance in GasCheck before opening Brows…#6099
Open
SeniorZhai wants to merge 1 commit intomasterfrom
Open
feat(web3): check Solana fee balance in GasCheck before opening Brows…#6099SeniorZhai wants to merge 1 commit intomasterfrom
SeniorZhai wants to merge 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Solana-specific balance check in the GasCheck flow to prevent opening the BrowserWallet sheet when the wallet lacks enough SOL to cover transaction fees.
Changes:
- Parse Solana raw (versioned) transactions in
GasCheckBottomSheetDialogFragmentto compute the required fee. - Fetch SOL balance for the current wallet and gate BrowserWallet sheet opening on sufficient fee balance.
- Show
TransferWeb3BalanceErrorBottomSheetDialogFragmentwhen SOL balance is insufficient.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| showBrowserWalletBottomSheet() | ||
| return | ||
| } | ||
| val solTokenItem: Web3TokenItem? = chainToken ?: viewModel.web3TokenItemById(Web3Signer.currentWalletId, Chain.Solana.chainId) |
There was a problem hiding this comment.
Chain.Solana.chainId is the WalletConnect-style chain identifier (e.g., solana:...), but web3TokenItemById(walletId, assetId) expects the Mixin chain/asset UUID (e.g., Constants.ChainId.SOLANA_CHAIN_ID, which is Chain.Solana.assetId). Using Chain.Solana.chainId here will likely return null and incorrectly show Data_error, blocking Solana signing when chainToken isn’t provided (e.g., Link flow).
Suggested change
| val solTokenItem: Web3TokenItem? = chainToken ?: viewModel.web3TokenItemById(Web3Signer.currentWalletId, Chain.Solana.chainId) | |
| val solTokenItem: Web3TokenItem? = chainToken ?: viewModel.web3TokenItemById(Web3Signer.currentWalletId, Chain.Solana.assetId) |
SeniorZhai
force-pushed
the
fix/solana-insufficient-sol-gate
branch
from
7e0d9a2 to
7d84d1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…erWallet sheet