Allow arbitrary generated folder location#969
Draft
keveleigh wants to merge 9 commits intoMixedRealityToolkit:mainfrom
Draft
Allow arbitrary generated folder location#969keveleigh wants to merge 9 commits intoMixedRealityToolkit:mainfrom
keveleigh wants to merge 9 commits intoMixedRealityToolkit:mainfrom
Conversation
keveleigh
requested review from
a team,
AMollis,
marlenaklein-msft and
shaynie
as code owners
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
e405455 to
f2abade
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
3 times, most recently
from
712caee to
ddee8ed
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
ddee8ed to
2759e4d
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
266bec0 to
41fe18b
Compare
whitetigerhelix
previously approved these changes
May 28, 2025
Contributor
whitetigerhelix
left a comment
whitetigerhelix
left a comment
There was a problem hiding this comment.
GetOrCreateGeneratedFolderPath and AssetPostprocessor aren't run very often, right? What specifically causes this to be run? Assuming that is rare, this looks fine to me.
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
41fe18b to
a1cf3ae
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
a1cf3ae to
8a56914
Compare
Contributor
Author
@whitetigerhelix AssetPostprocessor runs every time the asset database is re-imported, which shouldn't be super frequent, but will happen as assets are added/removed/changed in a project. |
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
548c9a3 to
89343ef
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
2 times, most recently
from
5511fe3 to
697a641
Compare
keveleigh
force-pushed
the
allow-arbitrary-generated-folder-location
branch
from
697a641 to
cb2df20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #922
Ports over the "folder sentinel" pattern from MRTK2 (microsoft/MixedRealityToolkit-Unity#5603)